From: David Howells <dhowells@redhat.com>
To: "Brian J. Watson" <Brian.J.Watson@compaq.com>
Cc: David Howells <dhowells@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG 2.4.7] enabling RWSEM_DEBUG
Date: Thu, 26 Jul 2001 17:13:32 +0100 [thread overview]
Message-ID: <1722.996164012@warthog.cambridge.redhat.com> (raw)
In-Reply-To: Message from "Brian J. Watson" <Brian.J.Watson@compaq.com> of "Wed, 25 Jul 2001 10:56:41 PDT." <3B5F0859.94557FF5@compaq.com>
> Unfortunately, I ran into a bug with enabling RWSEM_DEBUG. The bug still
> exists in 2.4.7.
Could you try applying the attached patch, please.
David
_______________________________________________________________________________
diff -uNr linux-2.4.7/include/linux/rwsem.h linux-rwsem/include/linux/rwsem.h
--- linux-2.4.7/include/linux/rwsem.h Mon Jul 23 08:19:21 2001
+++ linux-rwsem/include/linux/rwsem.h Thu Jul 26 16:42:50 2001
@@ -9,7 +9,7 @@
#include <linux/linkage.h>
-#define RWSEM_DEBUG 0
+#define RWSEM_DEBUG 1
#ifdef __KERNEL__
@@ -27,11 +27,13 @@
#include <asm/rwsem.h> /* use an arch-specific implementation */
#endif
-#ifndef rwsemtrace
+#ifndef rwsemtrace_defined
+#define rwsemtrace_defined
#if RWSEM_DEBUG
-extern void FASTCALL(rwsemtrace(struct rw_semaphore *sem, const char *str));
+extern void FASTCALL(__rwsemtrace(struct rw_semaphore *sem, const char *str));
+#define rwsemtrace(SEM,STR) __rwsemtrace(SEM,STR)
#else
-#define rwsemtrace(SEM,FMT)
+#define rwsemtrace(SEM,STR)
#endif
#endif
diff -uNr linux-2.4.7/lib/rwsem-spinlock.c linux-rwsem/lib/rwsem-spinlock.c
--- linux-2.4.7/lib/rwsem-spinlock.c Mon Jul 23 08:19:18 2001
+++ linux-rwsem/lib/rwsem-spinlock.c Thu Jul 26 16:41:02 2001
@@ -18,7 +18,7 @@
};
#if RWSEM_DEBUG
-void rwsemtrace(struct rw_semaphore *sem, const char *str)
+void __rwsemtrace(struct rw_semaphore *sem, const char *str)
{
if (sem->debug)
printk("[%d] %s({%d,%d})\n",
@@ -235,5 +235,5 @@
EXPORT_SYMBOL(__up_read);
EXPORT_SYMBOL(__up_write);
#if RWSEM_DEBUG
-EXPORT_SYMBOL(rwsemtrace);
+EXPORT_SYMBOL(__rwsemtrace);
#endif
diff -uNr linux-2.4.7/lib/rwsem.c linux-rwsem/lib/rwsem.c
--- linux-2.4.7/lib/rwsem.c Mon Jul 23 08:21:25 2001
+++ linux-rwsem/lib/rwsem.c Thu Jul 26 16:40:56 2001
@@ -16,8 +16,7 @@
};
#if RWSEM_DEBUG
-#undef rwsemtrace
-void rwsemtrace(struct rw_semaphore *sem, const char *str)
+void __rwsemtrace(struct rw_semaphore *sem, const char *str)
{
printk("sem=%p\n",sem);
printk("(sem)=%08lx\n",sem->count);
@@ -206,5 +205,5 @@
EXPORT_SYMBOL_NOVERS(rwsem_down_write_failed);
EXPORT_SYMBOL_NOVERS(rwsem_wake);
#if RWSEM_DEBUG
-EXPORT_SYMBOL(rwsemtrace);
+EXPORT_SYMBOL(__rwsemtrace);
#endif
next prev parent reply other threads:[~2001-07-26 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-10 3:32 [PATCH] read/write semaphore trylock routines - 2.4.6 Brian J. Watson
2001-07-10 7:32 ` David Howells
2001-07-11 3:20 ` Brian J. Watson
2001-07-18 23:22 ` Brian J. Watson
2001-07-19 7:41 ` David Howells
2001-07-25 17:56 ` [BUG 2.4.7] enabling RWSEM_DEBUG Brian J. Watson
2001-07-26 13:28 ` David Howells
2001-07-26 16:13 ` David Howells [this message]
2001-07-26 21:21 ` Brian J. Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1722.996164012@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=Brian.J.Watson@compaq.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox