From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B138B1A6190; Tue, 30 Jul 2024 16:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722356430; cv=none; b=hUriAUi+dqYBD+s7OPDyjPDmNY/62w+YAFp25tRDch1UGUlToqx/9q6+BhJfN0u8bfFUHZuY7aVEkljd+O1cY0w1vhjDRDYvISaEAmUvyBIpdmrtDUxUuxnr/8tQV7+CZWpSij9lT05G3XR39eEsJgEThlTo8cuUajTk6eBt8h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722356430; c=relaxed/simple; bh=BUUyY1NTz3JrwklnZ/Mk1s3DehDybPuYkwhI5XkEtLg=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=TH3IxE55ZtTxYsaYK7CmiffMJ8spqLR4oJeHrn1Fj4shj1rmAy99VTMKDEjNaR0j1YNNlWAilZPNOAbBZNmcvMhBGhazcErsI+dqbHftwkvTY2DjSf5fIOHUJsLIPamG6BRL75JupdI6SPeYaT68SOEFVCSYpEq5OF9ZqajxxCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WAcg5fZ1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WAcg5fZ1" Received: by smtp.kernel.org (Postfix) with ESMTPS id 85926C4AF0C; Tue, 30 Jul 2024 16:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722356430; bh=BUUyY1NTz3JrwklnZ/Mk1s3DehDybPuYkwhI5XkEtLg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=WAcg5fZ1skHq3iYqMc8IUfB/jA7JF4wcIzUJSb7VvWTkC3VWJ9cKGK6B/VoUaT9EM iEESRyZtsKQJpXDXeSpdk/tk/N2XVgJB4H10fKKY/C4cl1/d1mefL3hDmgbMDni52n OV5rO/OBi6OcEEP7X1trOUvQn//pUsrJBGSAIFU81u04QCz46/NfyYuk219b5PsCRR T97IbGQkEzwQDug5bzCN3zYpH2nLX1WyqbLefxuAC1MFcM2QJiOYvhfpn1HV/TwveW aYSOTuhn7jWLZuFafDSWDOLdU+ZBc3F7/L3kFnYbLU+z8Y6F88DmWCABtExJhokD7p y7aATP87ypOpA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 73D1DC6E398; Tue, 30 Jul 2024 16:20:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: mvpp2: Don't re-use loop iterator From: patchwork-bot+netdevbpf@kernel.org Message-Id: <172235643047.2398.10999820377012165647.git-patchwork-notify@kernel.org> Date: Tue, 30 Jul 2024 16:20:30 +0000 References: In-Reply-To: To: Dan Carpenter Cc: stefanc@marvell.com, marcin.s.wojtas@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 24 Jul 2024 11:06:56 -0500 you wrote: > This function has a nested loop. The problem is that both the inside > and outside loop use the same variable as an iterator. I found this > via static analysis so I'm not sure the impact. It could be that it > loops forever or, more likely, the loop exits early. > > Fixes: 3a616b92a9d1 ("net: mvpp2: Add TX flow control support for jumbo frames") > Signed-off-by: Dan Carpenter > > [...] Here is the summary with links: - [net] net: mvpp2: Don't re-use loop iterator https://git.kernel.org/netdev/net/c/0aa3ca956c46 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html