From: patchwork-bot+netdevbpf@kernel.org
To: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, martineau@kernel.org, geliang@kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 0/7] mptcp: fix endpoints with 'signal' and 'subflow' flags
Date: Fri, 02 Aug 2024 01:40:32 +0000 [thread overview]
Message-ID: <172256283237.5499.17809617500066693516.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240731-upstream-net-20240731-mptcp-endp-subflow-signal-v1-0-c8a9b036493b@kernel.org>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 31 Jul 2024 13:05:52 +0200 you wrote:
> When looking at improving the user experience around the MPTCP endpoints
> setup, I noticed that setting an endpoint with both the 'signal' and the
> 'subflow' flags -- as it has been done in the past by users according to
> bug reports we got -- was resulting on only announcing the endpoint, but
> not using it to create subflows: the 'subflow' flag was then ignored.
>
> My initial thought was to modify IPRoute2 to warn the user when the two
> flags were set, but it doesn't sound normal to ignore one of them. I
> then looked at modifying the kernel not to allow having the two flags
> set, but when discussing about that with Mat, we thought it was maybe
> not ideal to do that, as there might be use-cases, we might break some
> configs. Then I saw it was working before v5.17. So instead, I fixed the
> support on the kernel side (patch 5) using Paolo's suggestion. This also
> includes a fix on the options side (patch 1: for v5.11+), an explicit
> deny of some options combinations (patch 2: for v5.18+), and some
> refactoring (patches 3 and 4) to ease the inclusion of the patch 5.
>
> [...]
Here is the summary with links:
- [net,1/7] mptcp: fully established after ADD_ADDR echo on MPJ
https://git.kernel.org/netdev/net/c/d67c5649c154
- [net,2/7] mptcp: pm: deny endp with signal + subflow + port
https://git.kernel.org/netdev/net/c/8af1f11865f2
- [net,3/7] mptcp: pm: reduce indentation blocks
https://git.kernel.org/netdev/net/c/c95eb32ced82
- [net,4/7] mptcp: pm: don't try to create sf if alloc failed
https://git.kernel.org/netdev/net/c/cd7c957f936f
- [net,5/7] mptcp: pm: do not ignore 'subflow' if 'signal' flag is also set
https://git.kernel.org/netdev/net/c/85df533a787b
- [net,6/7] selftests: mptcp: join: ability to invert ADD_ADDR check
https://git.kernel.org/netdev/net/c/bec1f3b119eb
- [net,7/7] selftests: mptcp: join: test both signal & subflow
https://git.kernel.org/netdev/net/c/4d2868b5d191
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-08-02 1:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 11:05 [PATCH net 0/7] mptcp: fix endpoints with 'signal' and 'subflow' flags Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 1/7] mptcp: fully established after ADD_ADDR echo on MPJ Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 2/7] mptcp: pm: deny endp with signal + subflow + port Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 3/7] mptcp: pm: reduce indentation blocks Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 4/7] mptcp: pm: don't try to create sf if alloc failed Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 5/7] mptcp: pm: do not ignore 'subflow' if 'signal' flag is also set Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 6/7] selftests: mptcp: join: ability to invert ADD_ADDR check Matthieu Baerts (NGI0)
2024-07-31 11:05 ` [PATCH net 7/7] selftests: mptcp: join: test both signal & subflow Matthieu Baerts (NGI0)
2024-08-02 1:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172256283237.5499.17809617500066693516.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox