From: David Howells <dhowells@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] slow-work: add (module*)work->owner to fix races with module clients
Date: Fri, 26 Jun 2009 13:52:16 +0100 [thread overview]
Message-ID: <17232.1246020736@redhat.com> (raw)
In-Reply-To: <20090625014520.449.98923.stgit@dev.haskins.net>
Gregory Haskins <ghaskins@novell.com> wrote:
> The slow_work facility was designed to use reference counting instead of
> barriers for synchronization. The reference counting mechanism is
> implemented as a vtable op (->get_ref, ->put_ref) callback. This is
> problematic for module use of the slow_work facility because it is
> impossible to synchronize against the .text installed in the callbacks:
> There is no way to ensure that the slow-work threads have completely
> exited the .text in question and rmmod may yank it out from under the
> slow_work thread.
This seems reasonable. I'll get round to testing it if I can find the OOM bug
that's nobbling by test machine.
David
prev parent reply other threads:[~2009-06-26 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 1:49 [PATCH v3] slow-work: add (module*)work->owner to fix races with module clients Gregory Haskins
2009-06-26 12:00 ` Gregory Haskins
2009-06-26 13:28 ` Michael S. Tsirkin
2009-06-26 13:52 ` Gregory Haskins
2009-06-26 14:02 ` Michael S. Tsirkin
2009-06-26 14:08 ` Gregory Haskins
2009-06-26 14:15 ` Michael S. Tsirkin
2009-06-26 12:52 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17232.1246020736@redhat.com \
--to=dhowells@redhat.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox