[PATCH net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x

[PATCH net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x

[MD Danish Anwar]

Crash is seen on AM64x 10M link when connecting / disconnecting multiple
times.

The fix for this is to enable quirk_10m_link_issue for AM64x.

Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
NOTE: If quirk_10m_link_issue is set, the ICSSG driver enables IEP1 which
fixes the 10M link issue.

As per Roger Quadros <rogerq@kernel.org> 's suggestion [1], posting this
as a separate patch.

[1] https://lore.kernel.org/all/cde0064d-83dd-4a7f-8921-053c25aae08b@kernel.org/

 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3e51b3a9b0a5..e3451beed323 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1452,6 +1452,7 @@ static const struct prueth_pdata am654_icssg_pdata = {
 
 static const struct prueth_pdata am64x_icssg_pdata = {
 	.fdqring_mode = K3_RINGACC_RING_MODE_RING,
+	.quirk_10m_link_issue = 1,
 	.switch_mode = 1,
 };
 

base-commit: 82b8000c28b56b014ce52a1f1581bef4af148681
-- 
2.34.1

Re: [PATCH net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x

[Roger Quadros]

On 23/08/2024 15:04, MD Danish Anwar wrote:
> Crash is seen on AM64x 10M link when connecting / disconnecting multiple
> times.
> 
> The fix for this is to enable quirk_10m_link_issue for AM64x.
> 
> Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

Re: [PATCH net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 23 Aug 2024 17:34:12 +0530 you wrote:
> Crash is seen on AM64x 10M link when connecting / disconnecting multiple
> times.
> 
> The fix for this is to enable quirk_10m_link_issue for AM64x.
> 
> Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> [...]

Here is the summary with links:
  - [net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x
    https://git.kernel.org/netdev/net/c/e846be0fba85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html