From: Heiko Stuebner <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>, mark.rutland@arm.com
Cc: xf@rock-chips.com, linux-clk@vger.kernel.org,
huangtao@rock-chips.com, xxx@rock-chips.com, cl@rock-chips.com,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, mturquette@baylibre.com,
sboyd@codeaurora.org, zhengxing@rock-chips.com
Subject: Re: [PATCH v3 1/3] clk: rockchip: add dt-binding header for rk3128
Date: Tue, 23 May 2017 10:29:52 +0200 [thread overview]
Message-ID: <1725571.3NA4bbO7jm@phil> (raw)
In-Reply-To: <1495501865-18512-2-git-send-email-zhangqing@rock-chips.com>
Hi Elaine,
Am Dienstag, 23. Mai 2017, 09:11:03 CEST schrieb Elaine Zhang:
> Add the dt-bindings header for the rk3128,
> that gets shared between the clock controller and
> the clock references in the dts.
> Add softreset ID for rk3128.
> And it also applies to the RK3126 SoC.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> include/dt-bindings/clock/rk3128-cru.h | 283 +++++++++++++++++++++++++++++++++
> 1 file changed, 283 insertions(+)
> create mode 100644 include/dt-bindings/clock/rk3128-cru.h
>
> diff --git a/include/dt-bindings/clock/rk3128-cru.h b/include/dt-bindings/clock/rk3128-cru.h
> new file mode 100644
> index 000000000000..5f055a41584b
> --- /dev/null
> +++ b/include/dt-bindings/clock/rk3128-cru.h
[...]
> +#define SCLK_USB480M 154
> +#define SCLK_USB480M_PHY 155
We probably don't need the clock-id for USB480M_PHY, as it is an external
clock and is unused. Instead as I wrote in the previous patch, it should
be added to the list of external clocks in the binding txt document.
Heiko
next prev parent reply other threads:[~2017-05-23 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 1:11 [PATCH v3 0/3] clk: rockchip: support clk controller for RK3128 SoC Elaine Zhang
2017-05-23 1:11 ` [PATCH v3 1/3] clk: rockchip: add dt-binding header for rk3128 Elaine Zhang
2017-05-23 8:29 ` Heiko Stuebner [this message]
2017-05-23 1:11 ` [PATCH v3 2/3] dt-bindings: add bindings for rk3128 clock controller Elaine Zhang
2017-05-23 1:11 ` [PATCH v3 3/3] clk: rockchip: add clock controller for rk3128 Elaine Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1725571.3NA4bbO7jm@phil \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox