From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755407Ab3H3NOt (ORCPT ); Fri, 30 Aug 2013 09:14:49 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:44879 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329Ab3H3NOr convert rfc822-to-8bit (ORCPT ); Fri, 30 Aug 2013 09:14:47 -0400 From: "Rafael J. Wysocki" To: Daniel Fu Cc: "daniel.lezcano@linaro.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Johnny Qiu Subject: Re: [PATCH] cpuidle: Check cpuidle driver before add refcount Date: Fri, 30 Aug 2013 15:25:32 +0200 Message-ID: <1725801.dn2z0gQifB@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.11.0-rc7+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <1377863302-22465-1-git-send-email-danifu@nvidia.com> <2041584.4YznqfT0Od@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, August 30, 2013 08:26:34 PM Daniel Fu wrote: > X-NVConfidentiality: public > > In SMP, When doing the cpuidle driver registration. There maybe only 1 cpu have register cpuidle(CPU0), > but In the process of registration cpuidle driver, the scheduler maybe schedule the process to the other CPU (eg. CPU0 have heay load, migrate to CPU1) > cpuidle_get_driver() --> get_cpu() , will get CPU1, if CPU1 didn't register cpuidle driver, Will get NULL. > > I know we should prevent the registration migrate to the other CPU, but we should check drv before add refcount to prevent kernel panic at least, Right? Well, cpuidle_driver_ref() has only one caller, which is not the registration. However, the caller apparently assumes that that function may return NULL and cpuidle_driver_unref() check drv against NULL too, so cpuidle_driver_ref() should do that either. Did you see that problem in testing or just through code inspection? Rafael > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@sisk.pl] > Sent: 2013年8月30日 20:01 > To: Daniel Fu > Cc: daniel.lezcano@linaro.org; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; Johnny Qiu > Subject: Re: [PATCH] cpuidle: Check cpuidle driver before add refcount > > On Friday, August 30, 2013 07:48:22 PM Daniel Fu wrote: > > If the current CPU has no cpuidle driver, drv will be NULL. > > Check if we get drv successfully before add refount to prevent Kernel > > panic. > > What is the actual scenario that may lead to this panic? > > Rafael > > > > Signed-off-by: Daniel Fu > > --- > > drivers/cpuidle/driver.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c index > > 3ac499d..6e11701 100644 > > --- a/drivers/cpuidle/driver.c > > +++ b/drivers/cpuidle/driver.c > > @@ -331,7 +331,8 @@ struct cpuidle_driver *cpuidle_driver_ref(void) > > spin_lock(&cpuidle_driver_lock); > > > > drv = cpuidle_get_driver(); > > - drv->refcnt++; > > + if (drv) > > + drv->refcnt++; > > > > spin_unlock(&cpuidle_driver_lock); > > return drv; > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.