public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net v2] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL
@ 2024-09-16 18:57 Thomas Weißschuh
  2024-09-22 19:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2024-09-16 18:57 UTC (permalink / raw)
  To: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Alexander Aring
  Cc: netdev, linux-kernel, Thomas Weißschuh, Simon Horman

The rpl sr tunnel code contains calls to dst_cache_*() which are
only present when the dst cache is built.
Select DST_CACHE to build the dst cache, similar to other kconfig
options in the same file.
Compiling the rpl sr tunnel without DST_CACHE will lead to linker
errors.

Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
---
Changes in v2:
- Fix Signed-off-by
- Remove Cc stable as per net/ rules
- Add Simons tags
- Expand commit message a bit
- Link to v1: https://lore.kernel.org/r/20240916-ipv6_rpl_lwtunnel-dst_cache-v1-1-c34d5d7ba7f3@linutronix.de
---
This is currently affecting the s390 defconfig.
In my opinion this patch should also be backported to stable.
---
 net/ipv6/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 08d4b7132d4c..1c9c686d9522 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -323,6 +323,7 @@ config IPV6_RPL_LWTUNNEL
 	bool "IPv6: RPL Source Routing Header support"
 	depends on IPV6
 	select LWTUNNEL
+	select DST_CACHE
 	help
 	  Support for RFC6554 RPL Source Routing Header using the lightweight
 	  tunnels mechanism.

---
base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
change-id: 20240916-ipv6_rpl_lwtunnel-dst_cache-22561978f35f

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net v2] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL
  2024-09-16 18:57 [PATCH net v2] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL Thomas Weißschuh
@ 2024-09-22 19:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-22 19:00 UTC (permalink / raw)
  To: =?utf-8?q?Thomas_Wei=C3=9Fschuh_=3Cthomas=2Eweissschuh=40linutronix=2Ede=3E?=
  Cc: davem, dsahern, edumazet, kuba, pabeni, alex.aring, netdev,
	linux-kernel, horms

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 16 Sep 2024 20:57:13 +0200 you wrote:
> The rpl sr tunnel code contains calls to dst_cache_*() which are
> only present when the dst cache is built.
> Select DST_CACHE to build the dst cache, similar to other kconfig
> options in the same file.
> Compiling the rpl sr tunnel without DST_CACHE will lead to linker
> errors.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL
    https://git.kernel.org/netdev/net/c/93c21077bb9b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-22 19:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-16 18:57 [PATCH net v2] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL Thomas Weißschuh
2024-09-22 19:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox