[PATCH] samples/bpf:Remove unused variables

[PATCH] samples/bpf:Remove unused variables

[Zhu Jun]

The variable is never referenced in the code, just remove them

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 samples/bpf/tcbpf1_kern.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/samples/bpf/tcbpf1_kern.c b/samples/bpf/tcbpf1_kern.c
index e9356130f84e..dc4ba5fe9c73 100644
--- a/samples/bpf/tcbpf1_kern.c
+++ b/samples/bpf/tcbpf1_kern.c
@@ -56,7 +56,6 @@ SEC("classifier")
 int bpf_prog1(struct __sk_buff *skb)
 {
 	__u8 proto = load_byte(skb, ETH_HLEN + offsetof(struct iphdr, protocol));
-	long *value;
 
 	if (proto == IPPROTO_TCP) {
 		set_ip_tos(skb, 8);
-- 
2.17.1

Re: [PATCH] samples/bpf:Remove unused variables

[Yonghong Song]

On 8/20/24 1:17 AM, Zhu Jun wrote:
> The variable is never referenced in the code, just remove them
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Acked-by: Yonghong Song <yonghong.song@linux.dev>

[PATCH] samples/bpf: Remove unused variables

[Zhu Jun]

These variables are never referenced in the code, just remove them.

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 samples/bpf/tc_l2_redirect_kern.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/samples/bpf/tc_l2_redirect_kern.c b/samples/bpf/tc_l2_redirect_kern.c
index fd2fa0004330..0b48f7ddf521 100644
--- a/samples/bpf/tc_l2_redirect_kern.c
+++ b/samples/bpf/tc_l2_redirect_kern.c
@@ -58,7 +58,6 @@ static __always_inline bool is_vip_addr(__be16 eth_proto, __be32 daddr)
 SEC("l2_to_iptun_ingress_forward")
 int _l2_to_iptun_ingress_forward(struct __sk_buff *skb)
 {
-	struct bpf_tunnel_key tkey = {};
 	void *data = (void *)(long)skb->data;
 	struct eth_hdr *eth = data;
 	void *data_end = (void *)(long)skb->data_end;
@@ -205,7 +204,6 @@ int _l2_to_ip6tun_ingress_redirect(struct __sk_buff *skb)
 SEC("drop_non_tun_vip")
 int _drop_non_tun_vip(struct __sk_buff *skb)
 {
-	struct bpf_tunnel_key tkey = {};
 	void *data = (void *)(long)skb->data;
 	struct eth_hdr *eth = data;
 	void *data_end = (void *)(long)skb->data_end;
-- 
2.17.1

Re: [PATCH] samples/bpf: Remove unused variables

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed,  9 Oct 2024 01:21:38 -0700 you wrote:
> These variables are never referenced in the code, just remove them.
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>  samples/bpf/tc_l2_redirect_kern.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - samples/bpf: Remove unused variables
    https://git.kernel.org/bpf/bpf-next/c/965fdf95a327

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH] samples/bpf: Remove unused variables

[Zhu Jun]

These variables are never referenced in the code, just remove them

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 samples/bpf/tc_l2_redirect_kern.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/samples/bpf/tc_l2_redirect_kern.c b/samples/bpf/tc_l2_redirect_kern.c
index fd2fa0004330..729657d77802 100644
--- a/samples/bpf/tc_l2_redirect_kern.c
+++ b/samples/bpf/tc_l2_redirect_kern.c
@@ -64,8 +64,6 @@ int _l2_to_iptun_ingress_forward(struct __sk_buff *skb)
 	void *data_end = (void *)(long)skb->data_end;
 	int key = 0, *ifindex;
 
-	int ret;
-
 	if (data + sizeof(*eth) > data_end)
 		return TC_ACT_OK;
 
@@ -115,8 +113,6 @@ int _l2_to_iptun_ingress_redirect(struct __sk_buff *skb)
 	void *data_end = (void *)(long)skb->data_end;
 	int key = 0, *ifindex;
 
-	int ret;
-
 	if (data + sizeof(*eth) > data_end)
 		return TC_ACT_OK;
 
-- 
2.17.1

Re: [PATCH] samples/bpf: Remove unused variables

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Sun, 10 Nov 2024 22:23:12 -0800 you wrote:
> These variables are never referenced in the code, just remove them
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>  samples/bpf/tc_l2_redirect_kern.c | 4 ----
>  1 file changed, 4 deletions(-)

Here is the summary with links:
  - samples/bpf: Remove unused variables
    https://git.kernel.org/bpf/bpf-next/c/3fcfbfe307dd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] samples/bpf: Remove unused variables

[Andrii Nakryiko]

On Sun, Nov 10, 2024 at 10:23 PM Zhu Jun <zhujun2@cmss.chinamobile.com> wrote:
>
> These variables are never referenced in the code, just remove them
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>  samples/bpf/tc_l2_redirect_kern.c | 4 ----
>  1 file changed, 4 deletions(-)
>

applied to bpf-next (but added file name to subject, so not sure if
bot will pick this up)

> diff --git a/samples/bpf/tc_l2_redirect_kern.c b/samples/bpf/tc_l2_redirect_kern.c
> index fd2fa0004330..729657d77802 100644
> --- a/samples/bpf/tc_l2_redirect_kern.c
> +++ b/samples/bpf/tc_l2_redirect_kern.c
> @@ -64,8 +64,6 @@ int _l2_to_iptun_ingress_forward(struct __sk_buff *skb)
>         void *data_end = (void *)(long)skb->data_end;
>         int key = 0, *ifindex;
>
> -       int ret;
> -
>         if (data + sizeof(*eth) > data_end)
>                 return TC_ACT_OK;
>
> @@ -115,8 +113,6 @@ int _l2_to_iptun_ingress_redirect(struct __sk_buff *skb)
>         void *data_end = (void *)(long)skb->data_end;
>         int key = 0, *ifindex;
>
> -       int ret;
> -
>         if (data + sizeof(*eth) > data_end)
>                 return TC_ACT_OK;
>
> --
> 2.17.1
>
>
>
>