public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] net: usb: usbnet: fix race in probe failure
@ 2024-10-10 13:19 Oliver Neukum
  2024-10-15  9:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2024-10-10 13:19 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, netdev, linux-usb, linux-kernel
  Cc: Oliver Neukum

The same bug as in the disconnect code path also exists
in the case of a failure late during the probe process.
The flag must also be set.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/net/usb/usbnet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 2506aa8c603e..ee1b5fd7b491 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1870,6 +1870,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 	 * may trigger an error resubmitting itself and, worse,
 	 * schedule a timer. So we kill it all just in case.
 	 */
+	usbnet_mark_going_away(dev);
 	cancel_work_sync(&dev->kevent);
 	del_timer_sync(&dev->delay);
 	free_netdev(net);
-- 
2.46.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: usb: usbnet: fix race in probe failure
  2024-10-10 13:19 [PATCH net] net: usb: usbnet: fix race in probe failure Oliver Neukum
@ 2024-10-15  9:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-15  9:50 UTC (permalink / raw)
  To: Oliver Neukum
  Cc: davem, edumazet, kuba, pabeni, netdev, linux-usb, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 10 Oct 2024 15:19:14 +0200 you wrote:
> The same bug as in the disconnect code path also exists
> in the case of a failure late during the probe process.
> The flag must also be set.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> 
> [...]

Here is the summary with links:
  - [net] net: usb: usbnet: fix race in probe failure
    https://git.kernel.org/netdev/net/c/b62f4c186c70

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-15  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 13:19 [PATCH net] net: usb: usbnet: fix race in probe failure Oliver Neukum
2024-10-15  9:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox