From: patchwork-bot+netdevbpf@kernel.org
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: lars.povlsen@microchip.com, Steen.Hegelund@microchip.com,
daniel.machon@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
jensemil.schulzostergaard@microchip.com,
UNGLinuxDriver@microchip.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: microchip: vcap api: Fix memory leaks in vcap_api_encode_rule_test()
Date: Wed, 16 Oct 2024 01:50:32 +0000 [thread overview]
Message-ID: <172904343274.1354363.4060688551856463197.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241014121922.1280583-1-ruanjinjie@huawei.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 14 Oct 2024 20:19:22 +0800 you wrote:
> Commit a3c1e45156ad ("net: microchip: vcap: Fix use-after-free error in
> kunit test") fixed the use-after-free error, but introduced below
> memory leaks by removing necessary vcap_free_rule(), add it to fix it.
>
> unreferenced object 0xffffff80ca58b700 (size 192):
> comm "kunit_try_catch", pid 1215, jiffies 4294898264
> hex dump (first 32 bytes):
> 00 12 7a 00 05 00 00 00 0a 00 00 00 64 00 00 00 ..z.........d...
> 00 00 00 00 00 00 00 00 00 04 0b cc 80 ff ff ff ................
> backtrace (crc 9c09c3fe):
> [<0000000052a0be73>] kmemleak_alloc+0x34/0x40
> [<0000000043605459>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<0000000040a01b8d>] vcap_alloc_rule+0x3cc/0x9c4
> [<000000003fe86110>] vcap_api_encode_rule_test+0x1ac/0x16b0
> [<00000000b3595fc4>] kunit_try_run_case+0x13c/0x3ac
> [<0000000010f5d2bf>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<00000000c5d82c9a>] kthread+0x2e8/0x374
> [<00000000f4287308>] ret_from_fork+0x10/0x20
> unreferenced object 0xffffff80cc0b0400 (size 64):
> comm "kunit_try_catch", pid 1215, jiffies 4294898265
> hex dump (first 32 bytes):
> 80 04 0b cc 80 ff ff ff 18 b7 58 ca 80 ff ff ff ..........X.....
> 39 00 00 00 02 00 00 00 06 05 04 03 02 01 ff ff 9...............
> backtrace (crc daf014e9):
> [<0000000052a0be73>] kmemleak_alloc+0x34/0x40
> [<0000000043605459>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<000000000ff63fd4>] vcap_rule_add_key+0x2cc/0x528
> [<00000000dfdb1e81>] vcap_api_encode_rule_test+0x224/0x16b0
> [<00000000b3595fc4>] kunit_try_run_case+0x13c/0x3ac
> [<0000000010f5d2bf>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<00000000c5d82c9a>] kthread+0x2e8/0x374
> [<00000000f4287308>] ret_from_fork+0x10/0x20
> unreferenced object 0xffffff80cc0b0700 (size 64):
> comm "kunit_try_catch", pid 1215, jiffies 4294898265
> hex dump (first 32 bytes):
> 80 07 0b cc 80 ff ff ff 28 b7 58 ca 80 ff ff ff ........(.X.....
> 3c 00 00 00 00 00 00 00 01 2f 03 b3 ec ff ff ff <......../......
> backtrace (crc 8d877792):
> [<0000000052a0be73>] kmemleak_alloc+0x34/0x40
> [<0000000043605459>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<000000006eadfab7>] vcap_rule_add_action+0x2d0/0x52c
> [<00000000323475d1>] vcap_api_encode_rule_test+0x4d4/0x16b0
> [<00000000b3595fc4>] kunit_try_run_case+0x13c/0x3ac
> [<0000000010f5d2bf>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<00000000c5d82c9a>] kthread+0x2e8/0x374
> [<00000000f4287308>] ret_from_fork+0x10/0x20
> unreferenced object 0xffffff80cc0b0900 (size 64):
> comm "kunit_try_catch", pid 1215, jiffies 4294898266
> hex dump (first 32 bytes):
> 80 09 0b cc 80 ff ff ff 80 06 0b cc 80 ff ff ff ................
> 7d 00 00 00 01 00 00 00 00 00 00 00 ff 00 00 00 }...............
> backtrace (crc 34181e56):
> [<0000000052a0be73>] kmemleak_alloc+0x34/0x40
> [<0000000043605459>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<000000000ff63fd4>] vcap_rule_add_key+0x2cc/0x528
> [<00000000991e3564>] vcap_val_rule+0xcf0/0x13e8
> [<00000000fc9868e5>] vcap_api_encode_rule_test+0x678/0x16b0
> [<00000000b3595fc4>] kunit_try_run_case+0x13c/0x3ac
> [<0000000010f5d2bf>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<00000000c5d82c9a>] kthread+0x2e8/0x374
> [<00000000f4287308>] ret_from_fork+0x10/0x20
> unreferenced object 0xffffff80cc0b0980 (size 64):
> comm "kunit_try_catch", pid 1215, jiffies 4294898266
> hex dump (first 32 bytes):
> 18 b7 58 ca 80 ff ff ff 00 09 0b cc 80 ff ff ff ..X.............
> 67 00 00 00 00 00 00 00 01 01 74 88 c0 ff ff ff g.........t.....
> backtrace (crc 275fd9be):
> [<0000000052a0be73>] kmemleak_alloc+0x34/0x40
> [<0000000043605459>] __kmalloc_cache_noprof+0x26c/0x2f4
> [<000000000ff63fd4>] vcap_rule_add_key+0x2cc/0x528
> [<000000001396a1a2>] test_add_def_fields+0xb0/0x100
> [<000000006e7621f0>] vcap_val_rule+0xa98/0x13e8
> [<00000000fc9868e5>] vcap_api_encode_rule_test+0x678/0x16b0
> [<00000000b3595fc4>] kunit_try_run_case+0x13c/0x3ac
> [<0000000010f5d2bf>] kunit_generic_run_threadfn_adapter+0x80/0xec
> [<00000000c5d82c9a>] kthread+0x2e8/0x374
> [<00000000f4287308>] ret_from_fork+0x10/0x20
> ......
>
> [...]
Here is the summary with links:
- [net,v2] net: microchip: vcap api: Fix memory leaks in vcap_api_encode_rule_test()
https://git.kernel.org/netdev/net/c/217a3d98d1e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-10-16 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:19 [PATCH net v2] net: microchip: vcap api: Fix memory leaks in vcap_api_encode_rule_test() Jinjie Ruan
2024-10-16 1:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172904343274.1354363.4060688551856463197.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jensemil.schulzostergaard@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox