public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, martineau@kernel.org, geliang@kernel.org,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	syzbot+3c8b7a8e7df6a2a226ca@syzkaller.appspotmail.com
Subject: Re: [PATCH net] mptcp: pm: fix UaF read in mptcp_pm_nl_rm_addr_or_subflow
Date: Thu, 17 Oct 2024 10:20:31 +0000	[thread overview]
Message-ID: <172916043148.2424677.15397767732397939566.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241015-net-mptcp-uaf-pm-rm-v1-1-c4ee5d987a64@kernel.org>

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 15 Oct 2024 10:38:47 +0200 you wrote:
> Syzkaller reported this splat:
> 
>   ==================================================================
>   BUG: KASAN: slab-use-after-free in mptcp_pm_nl_rm_addr_or_subflow+0xb44/0xcc0 net/mptcp/pm_netlink.c:881
>   Read of size 4 at addr ffff8880569ac858 by task syz.1.2799/14662
> 
>   CPU: 0 UID: 0 PID: 14662 Comm: syz.1.2799 Not tainted 6.12.0-rc2-syzkaller-00307-g36c254515dc6 #0
>   Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
>   Call Trace:
>    <TASK>
>    __dump_stack lib/dump_stack.c:94 [inline]
>    dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
>    print_address_description mm/kasan/report.c:377 [inline]
>    print_report+0xc3/0x620 mm/kasan/report.c:488
>    kasan_report+0xd9/0x110 mm/kasan/report.c:601
>    mptcp_pm_nl_rm_addr_or_subflow+0xb44/0xcc0 net/mptcp/pm_netlink.c:881
>    mptcp_pm_nl_rm_subflow_received net/mptcp/pm_netlink.c:914 [inline]
>    mptcp_nl_remove_id_zero_address+0x305/0x4a0 net/mptcp/pm_netlink.c:1572
>    mptcp_pm_nl_del_addr_doit+0x5c9/0x770 net/mptcp/pm_netlink.c:1603
>    genl_family_rcv_msg_doit+0x202/0x2f0 net/netlink/genetlink.c:1115
>    genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
>    genl_rcv_msg+0x565/0x800 net/netlink/genetlink.c:1210
>    netlink_rcv_skb+0x165/0x410 net/netlink/af_netlink.c:2551
>    genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
>    netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
>    netlink_unicast+0x53c/0x7f0 net/netlink/af_netlink.c:1357
>    netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1901
>    sock_sendmsg_nosec net/socket.c:729 [inline]
>    __sock_sendmsg net/socket.c:744 [inline]
>    ____sys_sendmsg+0x9ae/0xb40 net/socket.c:2607
>    ___sys_sendmsg+0x135/0x1e0 net/socket.c:2661
>    __sys_sendmsg+0x117/0x1f0 net/socket.c:2690
>    do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
>    __do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
>    do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
>    entry_SYSENTER_compat_after_hwframe+0x84/0x8e
>   RIP: 0023:0xf7fe4579
>   Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00
>   RSP: 002b:00000000f574556c EFLAGS: 00000296 ORIG_RAX: 0000000000000172
>   RAX: ffffffffffffffda RBX: 000000000000000b RCX: 0000000020000140
>   RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
>   RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
>   R10: 0000000000000000 R11: 0000000000000296 R12: 0000000000000000
>   R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
>    </TASK>
> 
> [...]

Here is the summary with links:
  - [net] mptcp: pm: fix UaF read in mptcp_pm_nl_rm_addr_or_subflow
    https://git.kernel.org/netdev/net/c/7decd1f5904a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-10-17 10:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  8:38 [PATCH net] mptcp: pm: fix UaF read in mptcp_pm_nl_rm_addr_or_subflow Matthieu Baerts (NGI0)
2024-10-15 14:24 ` Paolo Abeni
2024-10-17 10:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172916043148.2424677.15397767732397939566.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geliang@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+3c8b7a8e7df6a2a226ca@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox