public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`
@ 2024-11-18  2:55 Mario Limonciello
  2024-11-19 15:45 ` Mario Limonciello
  2024-11-19 20:28 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Mario Limonciello @ 2024-11-18  2:55 UTC (permalink / raw)
  To: Mark Brown, Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda
  Cc: open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, Mario Limonciello, kernel test robot

From: Mario Limonciello <mario.limonciello@amd.com>

The pci-ps module now must have `SND_SOC_ACPI_AMD_MATCH` selected
to reference the `snd_soc_acpi_amd_acp63_sdw_machines` symbol.

Fixes: 56d540befd59 ("ASoC: amd: ps: add soundwire machines for acp6.3 platform")
Cc: Vijendar.Mukunda@amd.com
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411180658.mIeWje2V-lkp@intel.com/
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 sound/soc/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 6dec44f516c13..c7590d4989bba 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -163,6 +163,7 @@ config SND_SOC_AMD_SOUNDWIRE
 config SND_SOC_AMD_PS
         tristate "AMD Audio Coprocessor-v6.3 Pink Sardine support"
 	select SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
+	select SND_SOC_ACPI_AMD_MATCH
         depends on X86 && PCI && ACPI
         help
           This option enables Audio Coprocessor i.e ACP v6.3 support on
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`
  2024-11-18  2:55 [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS` Mario Limonciello
@ 2024-11-19 15:45 ` Mario Limonciello
  2024-11-19 20:28 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2024-11-19 15:45 UTC (permalink / raw)
  To: Mario Limonciello, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Vijendar Mukunda
  Cc: open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, kernel test robot

On 11/17/2024 20:55, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> The pci-ps module now must have `SND_SOC_ACPI_AMD_MATCH` selected
> to reference the `snd_soc_acpi_amd_acp63_sdw_machines` symbol.
> 
> Fixes: 56d540befd59 ("ASoC: amd: ps: add soundwire machines for acp6.3 platform")
> Cc: Vijendar.Mukunda@amd.com
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411180658.mIeWje2V-lkp@intel.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

LKP robot reported again, so one more tag to add.

Closes: 
https://lore.kernel.org/oe-kbuild-all/202411191418.xjxcQBNJ-lkp@intel.com/

> ---
>   sound/soc/amd/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 6dec44f516c13..c7590d4989bba 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -163,6 +163,7 @@ config SND_SOC_AMD_SOUNDWIRE
>   config SND_SOC_AMD_PS
>           tristate "AMD Audio Coprocessor-v6.3 Pink Sardine support"
>   	select SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
> +	select SND_SOC_ACPI_AMD_MATCH
>           depends on X86 && PCI && ACPI
>           help
>             This option enables Audio Coprocessor i.e ACP v6.3 support on


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`
  2024-11-18  2:55 [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS` Mario Limonciello
  2024-11-19 15:45 ` Mario Limonciello
@ 2024-11-19 20:28 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-11-19 20:28 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda,
	Mario Limonciello
  Cc: linux-sound, linux-kernel, Mario Limonciello, kernel test robot

On Sun, 17 Nov 2024 20:55:27 -0600, Mario Limonciello wrote:
> The pci-ps module now must have `SND_SOC_ACPI_AMD_MATCH` selected
> to reference the `snd_soc_acpi_amd_acp63_sdw_machines` symbol.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`
      commit: 0109ee00788e0ad7b888a799c26b5a93b343876b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-19 20:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-18  2:55 [PATCH] ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS` Mario Limonciello
2024-11-19 15:45 ` Mario Limonciello
2024-11-19 20:28 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox