public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] bpf, lsm: Remove getlsmprop hooks BTF IDs
@ 2024-11-25 19:53 Thomas Weißschuh
  2024-11-25 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2024-11-25 19:53 UTC (permalink / raw)
  To: KP Singh, Matt Bobrowski, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
	Yonghong Song, John Fastabend, Stanislav Fomichev, Hao Luo,
	Jiri Olsa, Paul Moore, Casey Schaufler
  Cc: bpf, linux-kernel, audit, selinux, Thomas Weißschuh

These hooks are not useful for BPF LSM currently.
Furthermore a recent renaming introduced build warnings:

  BTFIDS  vmlinux
WARN: resolve_btfids: unresolved symbol bpf_lsm_task_getsecid_obj
WARN: resolve_btfids: unresolved symbol bpf_lsm_current_getsecid_subj

Link: https://lore.kernel.org/lkml/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net/
Fixes: 37f670aacd48 ("lsm: use lsm_prop in security_current_getsecid")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v2:
- Delete instead of rename IDs
- Link to v1: https://lore.kernel.org/r/20241123-bpf_lsm_task_getsecid_obj-v1-1-0d0f94649e05@weissschuh.net
---
 kernel/bpf/bpf_lsm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
index 3bc61628ab251e05d7837eb27dabc3b62bcc4783..967492b65185fac5333fc22f4d2ad49cf59a6573 100644
--- a/kernel/bpf/bpf_lsm.c
+++ b/kernel/bpf/bpf_lsm.c
@@ -375,8 +375,6 @@ BTF_ID(func, bpf_lsm_socket_socketpair)
 
 BTF_ID(func, bpf_lsm_syslog)
 BTF_ID(func, bpf_lsm_task_alloc)
-BTF_ID(func, bpf_lsm_current_getsecid_subj)
-BTF_ID(func, bpf_lsm_task_getsecid_obj)
 BTF_ID(func, bpf_lsm_task_prctl)
 BTF_ID(func, bpf_lsm_task_setscheduler)
 BTF_ID(func, bpf_lsm_task_to_inode)

---
base-commit: 9f16d5e6f220661f73b36a4be1b21575651d8833
change-id: 20241123-bpf_lsm_task_getsecid_obj-afdd47f84c7f

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] bpf, lsm: Remove getlsmprop hooks BTF IDs
  2024-11-25 19:53 [PATCH v2] bpf, lsm: Remove getlsmprop hooks BTF IDs Thomas Weißschuh
@ 2024-11-25 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-25 22:20 UTC (permalink / raw)
  To: =?utf-8?q?Thomas_Wei=C3=9Fschuh_=3Clinux=40weissschuh=2Enet=3E?=
  Cc: kpsingh, mattbobrowski, ast, daniel, andrii, martin.lau, eddyz87,
	song, yonghong.song, john.fastabend, sdf, haoluo, jolsa, paul,
	casey, bpf, linux-kernel, audit, selinux

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Mon, 25 Nov 2024 20:53:07 +0100 you wrote:
> These hooks are not useful for BPF LSM currently.
> Furthermore a recent renaming introduced build warnings:
> 
>   BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_task_getsecid_obj
> WARN: resolve_btfids: unresolved symbol bpf_lsm_current_getsecid_subj
> 
> [...]

Here is the summary with links:
  - [v2] bpf, lsm: Remove getlsmprop hooks BTF IDs
    https://git.kernel.org/bpf/bpf/c/8618f5ffba4d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-25 22:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-25 19:53 [PATCH v2] bpf, lsm: Remove getlsmprop hooks BTF IDs Thomas Weißschuh
2024-11-25 22:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox