From: patchwork-bot+netdevbpf@kernel.org
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: mkubecek@suse.cz, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, o.rempel@pengutronix.de,
thomas.petazzoni@bootlin.com, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
richardcochran@gmail.com
Subject: Re: [PATCH net v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset
Date: Thu, 05 Dec 2024 03:20:33 +0000 [thread overview]
Message-ID: <173336883303.1427062.8314508421207042104.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241202153358.1142095-1-kory.maincent@bootlin.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 2 Dec 2024 16:33:57 +0100 you wrote:
> A bitset without mask in a _SET request means we want exactly the bits in
> the bitset to be set. This works correctly for compact format but when
> verbose format is parsed, ethnl_update_bitset32_verbose() only sets the
> bits present in the request bitset but does not clear the rest. The commit
> 6699170376ab ("ethtool: fix application of verbose no_mask bitset") fixes
> this issue by clearing the whole target bitmap before we start iterating.
> The solution proposed brought an issue with the behavior of the mod
> variable. As the bitset is always cleared the old value will always
> differ to the new value.
>
> [...]
Here is the summary with links:
- [net,v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset
https://git.kernel.org/netdev/net/c/910c4788d615
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-12-05 3:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 15:33 [PATCH net v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset Kory Maincent
2024-12-05 3:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173336883303.1427062.8314508421207042104.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox