From: patchwork-bot+netdevbpf@kernel.org
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, marc.dionne@auristor.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Fix ability to add more data to a call once MSG_MORE deasserted
Date: Tue, 17 Dec 2024 02:10:38 +0000 [thread overview]
Message-ID: <173440143824.415501.3353560173014525806.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <2870480.1734037462@warthog.procyon.org.uk>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 12 Dec 2024 21:04:22 +0000 you wrote:
> When userspace is adding data to an RPC call for transmission, it must pass
> MSG_MORE to sendmsg() if it intends to add more data in future calls to
> sendmsg(). Calling sendmsg() without MSG_MORE being asserted closes the
> transmission phase of the call (assuming sendmsg() adds all the data
> presented) and further attempts to add more data should be rejected.
>
> However, this is no longer the case. The change of call state that was
> previously the guard got bumped over to the I/O thread, which leaves a
> window for a repeat sendmsg() to insert more data. This previously went
> unnoticed, but the more recent patch that changed the structures behind the
> Tx queue added a warning:
>
> [...]
Here is the summary with links:
- [net-next] rxrpc: Fix ability to add more data to a call once MSG_MORE deasserted
https://git.kernel.org/netdev/net-next/c/ae4f89989479
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-12-17 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 21:04 [PATCH net-next] rxrpc: Fix ability to add more data to a call once MSG_MORE deasserted David Howells
2024-12-17 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173440143824.415501.3353560173014525806.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox