From: patchwork-bot+netdevbpf@kernel.org
To: Wang Liang <wangliang74@huawei.com>
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
luoxuanqiang@kylinos.cn, kuniyu@amazon.com,
yuehaibing@huawei.com, zhangchangzhong@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fix memory leak in tcp_conn_request()
Date: Mon, 23 Dec 2024 18:10:33 +0000 [thread overview]
Message-ID: <173497743378.3921163.15697697298645904400.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241219072859.3783576-1-wangliang74@huawei.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 19 Dec 2024 15:28:59 +0800 you wrote:
> If inet_csk_reqsk_queue_hash_add() return false, tcp_conn_request() will
> return without free the dst memory, which allocated in af_ops->route_req.
>
> Here is the kmemleak stack:
>
> unreferenced object 0xffff8881198631c0 (size 240):
> comm "softirq", pid 0, jiffies 4299266571 (age 1802.392s)
> hex dump (first 32 bytes):
> 00 10 9b 03 81 88 ff ff 80 98 da bc ff ff ff ff ................
> 81 55 18 bb ff ff ff ff 00 00 00 00 00 00 00 00 .U..............
> backtrace:
> [<ffffffffb93e8d4c>] kmem_cache_alloc+0x60c/0xa80
> [<ffffffffba11b4c5>] dst_alloc+0x55/0x250
> [<ffffffffba227bf6>] rt_dst_alloc+0x46/0x1d0
> [<ffffffffba23050a>] __mkroute_output+0x29a/0xa50
> [<ffffffffba23456b>] ip_route_output_key_hash+0x10b/0x240
> [<ffffffffba2346bd>] ip_route_output_flow+0x1d/0x90
> [<ffffffffba254855>] inet_csk_route_req+0x2c5/0x500
> [<ffffffffba26b331>] tcp_conn_request+0x691/0x12c0
> [<ffffffffba27bd08>] tcp_rcv_state_process+0x3c8/0x11b0
> [<ffffffffba2965c6>] tcp_v4_do_rcv+0x156/0x3b0
> [<ffffffffba299c98>] tcp_v4_rcv+0x1cf8/0x1d80
> [<ffffffffba239656>] ip_protocol_deliver_rcu+0xf6/0x360
> [<ffffffffba2399a6>] ip_local_deliver_finish+0xe6/0x1e0
> [<ffffffffba239b8e>] ip_local_deliver+0xee/0x360
> [<ffffffffba239ead>] ip_rcv+0xad/0x2f0
> [<ffffffffba110943>] __netif_receive_skb_one_core+0x123/0x140
>
> [...]
Here is the summary with links:
- [net] net: fix memory leak in tcp_conn_request()
https://git.kernel.org/netdev/net/c/4f4aa4aa2814
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-12-23 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 7:28 [PATCH net] net: fix memory leak in tcp_conn_request() Wang Liang
2024-12-23 18:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173497743378.3921163.15697697298645904400.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxuanqiang@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox