From: patchwork-bot+netdevbpf@kernel.org
To: Antonio Pastor <antonio.pastor@gmail.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, kuba@kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: 802: LLC+SNAP OID:PID lookup on start of skb data
Date: Sat, 04 Jan 2025 16:20:33 +0000 [thread overview]
Message-ID: <173600763303.2464594.17318802416653468706.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250103012303.746521-1-antonio.pastor@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 Jan 2025 20:23:00 -0500 you wrote:
> 802.2+LLC+SNAP frames received by napi_complete_done() with GRO and DSA
> have skb->transport_header set two bytes short, or pointing 2 bytes
> before network_header & skb->data. This was an issue as snap_rcv()
> expected offset to point to SNAP header (OID:PID), causing packet to
> be dropped.
>
> A fix at llc_fixup_skb() (a024e377efed) resets transport_header for any
> LLC consumers that may care about it, and stops SNAP packets from being
> dropped, but doesn't fix the problem which is that LLC and SNAP should
> not use transport_header offset.
>
> [...]
Here is the summary with links:
- [net,v2] net: 802: LLC+SNAP OID:PID lookup on start of skb data
https://git.kernel.org/netdev/net/c/1e9b0e1c550c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2025-01-04 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241220142020.1131017-1-antonio.pastor@gmail.com>
2024-12-23 13:39 ` [PATCH net v2] net: llc: explicitly set skb->transport_header Antonio Pastor
2024-12-23 13:54 ` Eric Dumazet
[not found] ` <c8145fd0-df13-4c6a-8678-fbf9547cc112@gmail.com>
2024-12-23 18:18 ` Eric Dumazet
2024-12-25 1:35 ` Antonio Pastor
2024-12-28 2:12 ` [PATCH net] net: 802: reset skb->transport_header Antonio Pastor
2024-12-30 8:26 ` Eric Dumazet
2025-01-03 0:18 ` Antonio Pastor
2025-01-03 1:23 ` [PATCH net v2] net: 802: LLC+SNAP OID:PID lookup on start of skb data Antonio Pastor
2025-01-03 8:46 ` Eric Dumazet
2025-01-04 16:20 ` patchwork-bot+netdevbpf [this message]
2024-12-25 1:07 ` [PATCH net v3] net: llc: reset skb->transport_header Antonio Pastor
2024-12-26 9:38 ` Eric Dumazet
2024-12-27 19:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173600763303.2464594.17318802416653468706.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=antonio.pastor@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox