From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671AbcF2VJ7 (ORCPT ); Wed, 29 Jun 2016 17:09:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43197 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750878AbcF2VJ6 (ORCPT ); Wed, 29 Jun 2016 17:09:58 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Thiago Jung Bauermann To: Dave Young Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, vgoyal@redhat.com, Eric Biederman Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Date: Wed, 29 Jun 2016 18:09:46 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-88-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160629194518.GA5488@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <1495163.EskJqap5EJ@hactar> <20160629194518.GA5488@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062921-0032-0000-0000-0000025FBBBE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062921-0033-0000-0000-00000E95778C Message-Id: <1736656.LVyt5NrzWE@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-29_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606290195 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Using one argument for both sounds more reasonable than using a > > > separate > > > argument for memory walk.. > > > > I agree. This patch doesn't use a separate top_down argument, it's the > > same patch I sent earlier except that the comments to struct kexec_buf > > are in patch 2/9. What do you think? > > It looks good except one nitpick inline.. > > > > +/** > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > purgatory > It is not necessary to use only for purgatory load.. Ok, what about this? /** * kexec_locate_mem_hole - find free memory in a given kimage. []'s Thiago Jung Bauermann IBM Linux Technology Center