public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc
@ 2025-01-10 10:31 Saket Kumar Bhaskar
  2025-01-15 14:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Saket Kumar Bhaskar @ 2025-01-10 10:31 UTC (permalink / raw)
  To: bpf, linux-kselftest, linux-kernel
  Cc: ast, hbathini, andrii, daniel, davem, kuba, hawk, martin.lau,
	eddyz87, song, yonghong.song, john.fastabend, kpsingh, sdf,
	haoluo, jolsa, mykolal, shuah

On powerpc cache line size is 128 bytes, so skb_shared_info must be
aligned accordingly.

Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
---
 tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c      | 2 ++
 tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
index 53d6ad8c2257..b2b2d85dbb1b 100644
--- a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
+++ b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
@@ -82,6 +82,8 @@ static void test_xdp_adjust_tail_grow2(void)
 	/* SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) */
 #if defined(__s390x__)
 	int tailroom = 512;
+#elif defined(__powerpc__)
+	int tailroom = 384;
 #else
 	int tailroom = 320;
 #endif
diff --git a/tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c b/tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c
index 81bb38d72ced..dc74d8cf9e3f 100644
--- a/tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c
+++ b/tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c
@@ -10,6 +10,8 @@ int _xdp_adjust_tail_grow(struct xdp_md *xdp)
 	/* SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) */
 #if defined(__TARGET_ARCH_s390)
 	int tailroom = 512;
+#elif defined(__TARGET_ARCH_powerpc)
+	int tailroom = 384;
 #else
 	int tailroom = 320;
 #endif
-- 
2.43.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc
  2025-01-10 10:31 [PATCH] selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc Saket Kumar Bhaskar
@ 2025-01-15 14:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-15 14:50 UTC (permalink / raw)
  To: Saket Kumar Bhaskar
  Cc: bpf, linux-kselftest, linux-kernel, ast, hbathini, andrii, daniel,
	davem, kuba, hawk, martin.lau, eddyz87, song, yonghong.song,
	john.fastabend, kpsingh, sdf, haoluo, jolsa, mykolal, shuah

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Fri, 10 Jan 2025 16:01:09 +0530 you wrote:
> On powerpc cache line size is 128 bytes, so skb_shared_info must be
> aligned accordingly.
> 
> Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c      | 2 ++
>  tools/testing/selftests/bpf/progs/test_xdp_adjust_tail_grow.c | 2 ++
>  2 files changed, 4 insertions(+)

Here is the summary with links:
  - selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc
    https://git.kernel.org/bpf/bpf-next/c/9fe17b7466f6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-15 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-10 10:31 [PATCH] selftests/bpf: Fix test_xdp_adjust_tail_grow2 selftest on powerpc Saket Kumar Bhaskar
2025-01-15 14:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox