The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Lee Jones <lee@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Ray Jui <rjui@broadcom.com>,  Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 Stanislav Jakubek <stano.jakubek@gmail.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	 Scott Branden <sbranden@broadcom.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/9] dt-bindings: mfd: brcm,bcm59056: Convert to YAML
Date: Sat, 15 Feb 2025 04:28:26 -0600	[thread overview]
Message-ID: <173961530505.188543.13359016373130021930.robh@kernel.org> (raw)
In-Reply-To: <20250215-bcm59054-v4-1-dbfb2d76a855@gmail.com>


On Sat, 15 Feb 2025 10:39:36 +0100, Artur Weber wrote:
> Convert devicetree bindings for the Broadcom BCM59056 PMU MFD from
> TXT to YAML format. This patch does not change any functionality;
> the bindings remain the same.
> 
> The bindings have been split into two parts: the MFD binding and
> a separate binding for the regulator node, to simplify the addition
> of other models later (which have different regulators).
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v4:
> - Made $ref use full schema path
> - Cleaned up example
> - Dropped regulator name list comment
> - Changed description of regulator binding to mention BCM59056
>   explicitly
> - Changed "Power Management IC" to "Power Management Unit" to match
>   official Broadcom naming
> - Renamed mfd/brcm,bcm59056.yaml to mfd/brcm,bcm590xx.yaml
> 
> Changes in v3:
> - Moved regulator node to separate binding
> - Removed quotes around compatibles/vbus property
> - Style fixes for example
> ---
>  .../devicetree/bindings/mfd/brcm,bcm59056.txt      | 39 ----------------
>  .../devicetree/bindings/mfd/brcm,bcm590xx.yaml     | 54 ++++++++++++++++++++++
>  .../bindings/regulator/brcm,bcm59056.yaml          | 51 ++++++++++++++++++++
>  3 files changed, 105 insertions(+), 39 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/regulator/brcm,bcm59056.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml
Documentation/devicetree/bindings/regulator/brcm,bcm59056.yaml: Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250215-bcm59054-v4-1-dbfb2d76a855@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-02-15 10:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-15  9:39 [PATCH v4 0/9] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-02-15  9:39 ` [PATCH v4 1/9] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-02-15 10:28   ` Rob Herring (Arm) [this message]
2025-02-15  9:39 ` [PATCH v4 2/9] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-02-15 10:28   ` Rob Herring (Arm)
2025-02-15  9:39 ` [PATCH v4 3/9] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-02-15  9:39 ` [PATCH v4 4/9] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-02-15  9:39 ` [PATCH v4 5/9] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-02-15  9:39 ` [PATCH v4 6/9] regulator: bcm590xx: Use dev_err_probe for regulator register error Artur Weber
2025-02-15  9:39 ` [PATCH v4 7/9] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-02-15  9:39 ` [PATCH v4 8/9] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-02-15  9:39 ` [PATCH v4 9/9] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-02-19  0:42 ` [PATCH v4 0/9] mfd: bcm590xx: Add support for BCM59054 Rob Herring (Arm)
2025-02-19  5:41   ` Artur Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173961530505.188543.13359016373130021930.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aweber.kernel@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stano.jakubek@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox