Re: [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe

[Yibo Dong <dong100@mucse.com>]

On Wed, Jul 23, 2025 at 09:09:34PM +0100, Simon Horman wrote:
> On Wed, Jul 23, 2025 at 11:01:11AM +0800, Yibo Dong wrote:
> > On Tue, Jul 22, 2025 at 12:29:09PM +0100, Simon Horman wrote:
> > > On Mon, Jul 21, 2025 at 07:32:24PM +0800, Dong Yibo wrote:
> 
> ...
> 
> > But I can't get this warning follow steps in my local:
> > ---
> > - make x86_64_defconfig
> > - make menuconfig  (select my driver rnpgbe to *)
> > - make W=1 -j 20
> > ---
> > if I compile it with 'make W=1 C=1 -j 20', some errors like this:
> > ---
> > ./include/linux/skbuff.h:978:1: error: directive in macro's argument list
> > ./include/linux/skbuff.h:981:1: error: directive in macro's argument list
> > ........
> > Segmentation fault
> > ---
> > I also tried to use nipa/tests/patch/build_allmodconfig_warn
> > /build_allmodconfig.sh (not run the bot, just copy this sh to source
> > code). It seems the same with 'make W=1 C=1 -j 20'.
> > Is there something wrong for me? I want to get the warnings locally,
> > then I can check it before sending patches. Any suggestions to me, please?
> > Thanks for your feedback.
> 
> I would expect what you are trying to work.

I want to reproduce the warning locally, like this: 
'warning: symbol 'rnpgbe_driver_name' was not declared. Should it be static'
Then, I can check codes before sending patches.

> And I certainly would not expect a segmentation fault.
> 
> I suspect that the version of Sparse you have is causing this problem
> (although it is just a wild guess). I would suggest installing
> from git. http://git.kernel.org/pub/scm/devel/sparse/sparse.git
> 
> The current HEAD is commit 0196afe16a50 ("Merge branch 'riscv'").
> I have exercised it quite a lot.
> 

nice, after installation, it works. I reproduced the warning, thanks.

> For reference, I also use:
> GCC 15.1.0 from here: https://mirrors.edge.kernel.org/pub/tools/crosstool/
> Clang 20.1.8 from here: https://mirrors.edge.kernel.org/pub/tools/llvm/
> (Because they are the latest non -rc compilers available there)
> 
>