From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22341CAAE for ; Mon, 22 Apr 2024 21:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713821414; cv=none; b=tszwcvPUoT1U+aRcabpejA97eI2RA3E3sBxY4eIbwkn3P5P63xl2YFhpbczI3i8lreX+k2PMP0rLQibHlzo7xfauSiaIlpt0MQrlmmMh84MGkekheWAa4UPr5Ejhcmmxkur/VdRJe9Y/jPvpXOVxJR3Mbim1xAXY/stM9WSj73s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713821414; c=relaxed/simple; bh=Ku1DGEy0db+OnEa5w7PseS2QxxW9d5ZfsbNmxLSkJk4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HyjUXo6KZyIxMg+w7Y7xUI/tS5d6hbiZXfz3bMoJpJLi8iCR/DclZ/sgUa4nnJxQ15cZ8+XRHA2i9fdJUHpGz0y79T1rAwKwkMaR7FWSyKc/zXyMHFrR5GxZZPDqNBBAhINCz7lnxyPP+PbKDcB3Y4erjFxeW5zuuoj8RQiTgzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mWuX9Kg/; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mWuX9Kg/" Message-ID: <173a7bb2-5473-4c1b-b3dd-ef776e63ac7a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713821410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nH11/CXhaPQDxPvStD1h8S0lo64PkavloRKwmStdkfE=; b=mWuX9Kg/JSi1GlYagbN/iSGyHb/7PXLCjJlVe2ffi1+IfdKuKtnzjNx4prIYV7NtPx33eP 8B5u1AI13YXJt+teLHVOvg75/U1S+3pRwtbXlsY/OMJnyiEvQkkBySvgFP0vw/MxqUcOGj Qy2HIzwX+531fGEzPAj3ctd1ecHdlnk= Date: Mon, 22 Apr 2024 17:30:06 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/7] dt-bindings: pci: xilinx-nwl: Add phys To: Rob Herring Cc: Michal Simek , Thippeswamy Havalige , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Conor Dooley , linux-kernel@vger.kernel.org, Bjorn Helgaas , Krzysztof Kozlowski , devicetree@vger.kernel.org, Lorenzo Pieralisi References: <20240422195904.3591683-1-sean.anderson@linux.dev> <20240422195904.3591683-2-sean.anderson@linux.dev> <171382130333.1986303.15938018699322126426.robh@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <171382130333.1986303.15938018699322126426.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/22/24 17:28, Rob Herring wrote: > > On Mon, 22 Apr 2024 15:58:58 -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson >> --- >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']} > hint: "maxItems" is not needed with an "items" list > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240422195904.3591683-2-sean.anderson@linux.dev > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > This warning is invalid, since I am using pattern with items. --Sean