From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BA2C433F5 for ; Thu, 6 Sep 2018 10:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D558C20857 for ; Thu, 6 Sep 2018 10:08:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D558C20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728440AbeIFOmz (ORCPT ); Thu, 6 Sep 2018 10:42:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726105AbeIFOmz (ORCPT ); Thu, 6 Sep 2018 10:42:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 076FB804BBBC; Thu, 6 Sep 2018 10:08:12 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44E2410073D1; Thu, 6 Sep 2018 10:08:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1536224508-66168-1-git-send-email-gaoxiang25@huawei.com> References: <1536224508-66168-1-git-send-email-gaoxiang25@huawei.com> To: Gao Xiang Cc: dhowells@redhat.com, Alexander Viro , Greg Kroah-Hartman , LKML , devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , weidu.du@huawei.com Subject: Re: [PATCH 1/2 dhowells/mount-api] staging: erofs: rename superblock flags (MS_xyz -> SB_xyz) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17401.1536228489.1@warthog.procyon.org.uk> Date: Thu, 06 Sep 2018 11:08:09 +0100 Message-ID: <17402.1536228489@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 06 Sep 2018 10:08:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 06 Sep 2018 10:08:12 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gao Xiang wrote: > This patch follows commit 1751e8a6cb93 ("Rename superblock > flags (MS_xyz -> SB_xyz)") and after commit ("vfs: Suppress > MS_* flag defs within the kernel unless explicitly enabled"), > there is no MS_RDONLY and MS_NOATIME at all. > > Reported-by: Stephen Rothwell > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang I recommend pushing this one to Linus now. It's trivial enough. Reviewed-by: David Howells