The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matt Coster <matt.coster@imgtec.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-kernel@vger.kernel.org,
	Alessio Belle <alessio.belle@imgtec.com>,
	 David Airlie <airlied@gmail.com>, Nishanth Menon <nm@ti.com>,
	 dri-devel@lists.freedesktop.org,
	Frank Binns <frank.binns@imgtec.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Tero Kristo <kristo@kernel.org>,
	 Darren Etheridge <detheridge@ti.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Alexandru Dadu <alexandru.dadu@imgtec.com>,
	Randolph Sapp <rs@ti.com>,  Maxime Ripard <mripard@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v3 02/18] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings
Date: Mon, 10 Mar 2025 09:40:08 -0500	[thread overview]
Message-ID: <174161760641.1135.692000381478156014.robh@kernel.org> (raw)
In-Reply-To: <20250310-sets-bxs-4-64-patch-v1-v3-2-143b3dbef02f@imgtec.com>


On Mon, 10 Mar 2025 13:10:26 +0000, Matt Coster wrote:
> Unlike AXE-1-16M, BXS-4-64 uses two power domains.
> 
> Like the existing AXE-1-16M integration, BXS-4-64 uses the single clock
> integration in the TI k3-j721s2.
> 
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> ---
> Changes in v3:
> - Include adding the second power domain so it's in context
> - Remove unnecessary example
> - Link to v2: https://lore.kernel.org/r/20241118-sets-bxs-4-64-patch-v1-v2-8-3fd45d9fb0cf@imgtec.com
> Changes in v2:
> - Use normal reg syntax for 64-bit values
> - Link to v1: https://lore.kernel.org/r/20241105-sets-bxs-4-64-patch-v1-v1-8-4ed30e865892@imgtec.com
> ---
>  .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 34 +++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpu/img,powervr-rogue.example.dtb: gpu@fd00000: power-domain-names: ['a'] is too short
	from schema $id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250310-sets-bxs-4-64-patch-v1-v3-2-143b3dbef02f@imgtec.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-03-10 14:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 13:10 [PATCH v3 00/18] Imagination BXS-4-64 MC1 GPU support Matt Coster
2025-03-10 13:10 ` [PATCH v3 01/18] dt-bindings: gpu: img: Future-proofing enhancements Matt Coster
2025-03-11  7:50   ` Krzysztof Kozlowski
2025-03-11 10:33     ` Matt Coster
2025-03-11 13:25       ` Krzysztof Kozlowski
2025-03-10 13:10 ` [PATCH v3 02/18] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings Matt Coster
2025-03-10 14:40   ` Rob Herring (Arm)
2025-03-10 14:40   ` Rob Herring (Arm) [this message]
2025-03-11  7:51   ` Krzysztof Kozlowski
2025-03-11 10:28     ` Matt Coster
2025-03-10 13:10 ` [PATCH v3 03/18] drm/imagination: Update register defs for newer GPUs Matt Coster
2025-03-10 13:10 ` [PATCH v3 04/18] drm/imagination: Use new generic compatible string Matt Coster
2025-03-10 13:10 ` [PATCH v3 05/18] drm/imagination: Add power domain control Matt Coster
2025-03-10 13:10 ` [PATCH v3 06/18] drm/imagination: Mask GPU IRQs in threaded handler Matt Coster
2025-03-10 13:10 ` [PATCH v3 07/18] drm/imagination: Handle Rogue safety event IRQs Matt Coster
2025-03-10 13:10 ` [PATCH v3 08/18] drm/imagination: Remove firmware enable_reg Matt Coster
2025-03-10 13:10 ` [PATCH v3 09/18] drm/imagination: Rename event_mask -> status_mask Matt Coster
2025-03-10 13:10 ` [PATCH v3 10/18] drm/imagination: Make has_fixed_data_addr a value Matt Coster
2025-03-10 13:10 ` [PATCH v3 11/18] drm/imagination: Use a lookup table for fw defs Matt Coster
2025-03-10 13:10 ` [PATCH v3 12/18] drm/imagination: Use callbacks for fw irq handling Matt Coster
2025-03-10 13:10 ` [PATCH v3 13/18] drm/imagination: Move ELF fw utils to common file Matt Coster
2025-03-10 13:10 ` [PATCH v3 14/18] drm/imagination: Add RISC-V firmware processor support Matt Coster
2025-03-10 13:10 ` [PATCH v3 15/18] drm/imagination: Use cached memory with dma_coherent Matt Coster
2025-03-10 13:10 ` [PATCH v3 16/18] drm/imagination: Add support for TI AM68 GPU Matt Coster
2025-03-10 13:10 ` [PATCH DO NOT MERGE v3 17/18] arm64: dts: ti: k3-am62: New GPU binding details Matt Coster
2025-03-10 13:10 ` [PATCH DO NOT MERGE v3 18/18] arm64: dts: ti: k3-j721s2: Add GPU node Matt Coster
2025-03-11 15:19 ` [PATCH v3 00/18] Imagination BXS-4-64 MC1 GPU support Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174161760641.1135.692000381478156014.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alessio.belle@imgtec.com \
    --cc=alexandru.dadu@imgtec.com \
    --cc=conor+dt@kernel.org \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=rs@ti.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox