* [PATCH] selftests/bpf: Fix bpf_nf selftest failure
@ 2025-04-09 9:56 Saket Kumar Bhaskar
2025-04-09 23:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Saket Kumar Bhaskar @ 2025-04-09 9:56 UTC (permalink / raw)
To: bpf, linux-kselftest, linux-kernel
Cc: ast, hbathini, andrii, daniel, mykolal, martin.lau, song,
yonghong.song, john.fastabend, kpsingh, sdf, haoluo, jolsa, shuah
For systems with missing iptables-legacy tool, this selftest fails.
Add check to find if iptables-legacy tool is available and skip the
test if the tool is missing.
Fixes: de9c8d848d90 ("selftests/bpf: S/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test")
Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
---
tools/testing/selftests/bpf/prog_tests/bpf_nf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c
index dbd13f8e42a7..dd6512fa652b 100644
--- a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c
+++ b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c
@@ -63,6 +63,12 @@ static void test_bpf_nf_ct(int mode)
.repeat = 1,
);
+ if (SYS_NOFAIL("iptables-legacy --version")) {
+ fprintf(stdout, "Missing required iptables-legacy tool\n");
+ test__skip();
+ return;
+ }
+
skel = test_bpf_nf__open_and_load();
if (!ASSERT_OK_PTR(skel, "test_bpf_nf__open_and_load"))
return;
--
2.43.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/bpf: Fix bpf_nf selftest failure
2025-04-09 9:56 [PATCH] selftests/bpf: Fix bpf_nf selftest failure Saket Kumar Bhaskar
@ 2025-04-09 23:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-09 23:40 UTC (permalink / raw)
To: Saket Kumar Bhaskar
Cc: bpf, linux-kselftest, linux-kernel, ast, hbathini, andrii, daniel,
mykolal, martin.lau, song, yonghong.song, john.fastabend, kpsingh,
sdf, haoluo, jolsa, shuah
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 9 Apr 2025 15:26:33 +0530 you wrote:
> For systems with missing iptables-legacy tool, this selftest fails.
>
> Add check to find if iptables-legacy tool is available and skip the
> test if the tool is missing.
>
> Fixes: de9c8d848d90 ("selftests/bpf: S/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test")
> Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
>
> [...]
Here is the summary with links:
- selftests/bpf: Fix bpf_nf selftest failure
https://git.kernel.org/bpf/bpf-next/c/967e8def1100
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-09 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 9:56 [PATCH] selftests/bpf: Fix bpf_nf selftest failure Saket Kumar Bhaskar
2025-04-09 23:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox