* Re: [PATCH v4 0/3] devfreq: Add support for devices which can idle
@ 2012-10-04 12:36 MyungJoo Ham
2012-10-05 4:53 ` Rajagopal Venkat
0 siblings, 1 reply; 3+ messages in thread
From: MyungJoo Ham @ 2012-10-04 12:36 UTC (permalink / raw)
To: Rajagopal Venkat, mturquette@linaro.org, 박경민,
rjw@sisk.pl
Cc: patches@linaro.org, linaro-dev@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2351 bytes --]
> This patchset updates devfreq core to add support for devices
> which can idle. When device idleness is detected perhaps
> through runtime-pm, need some mechanism to suspend devfreq
> load monitoring and resume when device is back online.
>
> patch 1 introduce core design changes - per device work, decouple
> delayed work from core and event based interaction.
> patch 2 add devfreq suspend and resume apis.
> patch 3 add new sysfs attribute for governor predicted next target
> frequency and callback for current device frequency.
>
> The existing devfreq apis are kept intact. Two new apis
> devfreq_suspend_device() and devfreq_resume_device() are
> added to support suspend/resume of device devfreq.
Could you please tell me which version you have rebased?
It seems that the patchset has issues on applying over 3.6.
(tried at a0d271cbfed1dd50278c6b06bead3d00ba0a88f9)
>
> Changes since v1:
> - revised locking mechanism
> - added kerneldoc comments for load monitoring helper functions
> - fixed minor review comments
>
> Changes since v2:
> - added new helper function for polling interval update
> - handled work suspend/resume contention between devfreq driver
> and sysfs
>
> Changes since v3:
> - added additonal checks in suspend/resume to avoid invalid usage of apis
> - added check in devfreq_monitor_start, not to start monitoring when
> polling_ms is set to zero.
>
> --
> Rajagopal Venkat (3):
> devfreq: Core updates to support devices which can idle
> devfreq: Add suspend and resume apis
> devfreq: Add current freq callback in device profile
>
> Documentation/ABI/testing/sysfs-class-devfreq | 15 +-
> drivers/devfreq/devfreq.c | 481 ++++++++++++--------------
> drivers/devfreq/governor.h | 13 +
> drivers/devfreq/governor_performance.c | 16 +-
> drivers/devfreq/governor_powersave.c | 16 +-
> drivers/devfreq/governor_simpleondemand.c | 33 ++
> drivers/devfreq/governor_userspace.c | 23 +-
> include/linux/devfreq.h | 49 +--
> 8 files changed, 353 insertions(+), 293 deletions(-)
>
> --
> 1.7.11.3
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v4 0/3] devfreq: Add support for devices which can idle
2012-10-04 12:36 [PATCH v4 0/3] devfreq: Add support for devices which can idle MyungJoo Ham
@ 2012-10-05 4:53 ` Rajagopal Venkat
0 siblings, 0 replies; 3+ messages in thread
From: Rajagopal Venkat @ 2012-10-05 4:53 UTC (permalink / raw)
To: myungjoo.ham
Cc: mturquette@linaro.org, 박경민, rjw@sisk.pl,
patches@linaro.org, linaro-dev@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
On 4 October 2012 18:06, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
>> This patchset updates devfreq core to add support for devices
>> which can idle. When device idleness is detected perhaps
>> through runtime-pm, need some mechanism to suspend devfreq
>> load monitoring and resume when device is back online.
>>
>> patch 1 introduce core design changes - per device work, decouple
>> delayed work from core and event based interaction.
>> patch 2 add devfreq suspend and resume apis.
>> patch 3 add new sysfs attribute for governor predicted next target
>> frequency and callback for current device frequency.
>>
>> The existing devfreq apis are kept intact. Two new apis
>> devfreq_suspend_device() and devfreq_resume_device() are
>> added to support suspend/resume of device devfreq.
>
> Could you please tell me which version you have rebased?
>
> It seems that the patchset has issues on applying over 3.6.
> (tried at a0d271cbfed1dd50278c6b06bead3d00ba0a88f9)
These patches are rebased against Linus tree.
The 203b42f7317494ae5e5efc7be6fb7f29c927f102 commit, which
renames INIT_DELAYED_WORK_DEFERRABLE to
INIT_DEFERRABLE_WORK could be the reason for patchset
not applying over 3.6.
>
>
>>
>> Changes since v1:
>> - revised locking mechanism
>> - added kerneldoc comments for load monitoring helper functions
>> - fixed minor review comments
>>
>> Changes since v2:
>> - added new helper function for polling interval update
>> - handled work suspend/resume contention between devfreq driver
>> and sysfs
>>
>> Changes since v3:
>> - added additonal checks in suspend/resume to avoid invalid usage of apis
>> - added check in devfreq_monitor_start, not to start monitoring when
>> polling_ms is set to zero.
>>
>> --
>> Rajagopal Venkat (3):
>> devfreq: Core updates to support devices which can idle
>> devfreq: Add suspend and resume apis
>> devfreq: Add current freq callback in device profile
>>
>> Documentation/ABI/testing/sysfs-class-devfreq | 15 +-
>> drivers/devfreq/devfreq.c | 481 ++++++++++++--------------
>> drivers/devfreq/governor.h | 13 +
>> drivers/devfreq/governor_performance.c | 16 +-
>> drivers/devfreq/governor_powersave.c | 16 +-
>> drivers/devfreq/governor_simpleondemand.c | 33 ++
>> drivers/devfreq/governor_userspace.c | 23 +-
>> include/linux/devfreq.h | 49 +--
>> 8 files changed, 353 insertions(+), 293 deletions(-)
>>
>> --
>> 1.7.11.3
>>
>>
>>
>>
>>
>>
>>
>>
--
Regards,
Rajagopal
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 0/3] devfreq: Add support for devices which can idle
@ 2012-10-04 9:28 Rajagopal Venkat
0 siblings, 0 replies; 3+ messages in thread
From: Rajagopal Venkat @ 2012-10-04 9:28 UTC (permalink / raw)
To: myungjoo.ham, mturquette, kyungmin.park, rjw
Cc: patches, linaro-dev, linux-pm, linux-kernel, Rajagopal Venkat
This patchset updates devfreq core to add support for devices
which can idle. When device idleness is detected perhaps
through runtime-pm, need some mechanism to suspend devfreq
load monitoring and resume when device is back online.
patch 1 introduce core design changes - per device work, decouple
delayed work from core and event based interaction.
patch 2 add devfreq suspend and resume apis.
patch 3 add new sysfs attribute for governor predicted next target
frequency and callback for current device frequency.
The existing devfreq apis are kept intact. Two new apis
devfreq_suspend_device() and devfreq_resume_device() are
added to support suspend/resume of device devfreq.
Changes since v1:
- revised locking mechanism
- added kerneldoc comments for load monitoring helper functions
- fixed minor review comments
Changes since v2:
- added new helper function for polling interval update
- handled work suspend/resume contention between devfreq driver
and sysfs
Changes since v3:
- added additonal checks in suspend/resume to avoid invalid usage of apis
- added check in devfreq_monitor_start, not to start monitoring when
polling_ms is set to zero.
--
Rajagopal Venkat (3):
devfreq: Core updates to support devices which can idle
devfreq: Add suspend and resume apis
devfreq: Add current freq callback in device profile
Documentation/ABI/testing/sysfs-class-devfreq | 15 +-
drivers/devfreq/devfreq.c | 481 ++++++++++++--------------
drivers/devfreq/governor.h | 13 +
drivers/devfreq/governor_performance.c | 16 +-
drivers/devfreq/governor_powersave.c | 16 +-
drivers/devfreq/governor_simpleondemand.c | 33 ++
drivers/devfreq/governor_userspace.c | 23 +-
include/linux/devfreq.h | 49 +--
8 files changed, 353 insertions(+), 293 deletions(-)
--
1.7.11.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-05 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 12:36 [PATCH v4 0/3] devfreq: Add support for devices which can idle MyungJoo Ham
2012-10-05 4:53 ` Rajagopal Venkat
-- strict thread matches above, loose matches on Subject: below --
2012-10-04 9:28 Rajagopal Venkat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).