From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, claudiu.manoil@nxp.com, wei.fang@nxp.com,
xiaoning.wang@nxp.com, vlatko.markovikj@etas.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
lorenzo@kernel.org, toke@redhat.com,
aleksander.lobakin@intel.com, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net 0/3] ENETC bug fixes for bpf_xdp_adjust_head() and bpf_xdp_adjust_tail()
Date: Tue, 22 Apr 2025 09:10:04 +0000 [thread overview]
Message-ID: <174531300475.1477965.2995189751191314193.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250417120005.3288549-1-vladimir.oltean@nxp.com>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Apr 2025 15:00:02 +0300 you wrote:
> It has been reported that on the ENETC driver, bpf_xdp_adjust_head()
> and bpf_xdp_adjust_tail() are broken in combination with the XDP_PASS
> verdict. I have constructed a series a simple XDP programs and tested
> with various packet sizes and confirmed that this is the case.
>
> Patch 3/3 fixes the core issue, which is that the sk_buff created on
> XDP_PASS is created by the driver as if XDP never ran, but in fact the
> geometry needs to be adjusted according to the delta applied by the
> program on the original xdp_buff. It depends on commit 539c1fba1ac7
> ("xdp: add generic xdp_build_skb_from_buff()") which is not available in
> "stable" but perhaps should be.
>
> [...]
Here is the summary with links:
- [net,1/3] net: enetc: register XDP RX queues with frag_size
https://git.kernel.org/netdev/net/c/2768b2e2f7d2
- [net,2/3] net: enetc: refactor bulk flipping of RX buffers to separate function
https://git.kernel.org/netdev/net/c/1d587faa5be7
- [net,3/3] net: enetc: fix frame corruption on bpf_xdp_adjust_head/tail() and XDP_PASS
https://git.kernel.org/netdev/net/c/020f0c8b3d39
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-22 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 12:00 [PATCH net 0/3] ENETC bug fixes for bpf_xdp_adjust_head() and bpf_xdp_adjust_tail() Vladimir Oltean
2025-04-17 12:00 ` [PATCH net 1/3] net: enetc: register XDP RX queues with frag_size Vladimir Oltean
2025-04-18 7:26 ` Wei Fang
2025-04-17 12:00 ` [PATCH net 2/3] net: enetc: refactor bulk flipping of RX buffers to separate function Vladimir Oltean
2025-04-18 7:44 ` Wei Fang
2025-04-17 12:00 ` [PATCH net 3/3] net: enetc: fix frame corruption on bpf_xdp_adjust_head/tail() and XDP_PASS Vladimir Oltean
2025-04-21 6:05 ` Wei Fang
2025-04-22 9:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174531300475.1477965.2995189751191314193.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=vlatko.markovikj@etas.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox