Re: [PATCH v2 17/57] irqdomain: gpio: Switch to irq_domain_create_*()

Jiri Slaby
2025-03-20T06:11:25Z

On 19. 03. 25, 11:40, Andy Shevchenko wrote:
> On Wed, Mar 19, 2025 at 10:29:10AM +0100, Jiri Slaby (SUSE) wrote:
>> irq_domain_add_*() interfaces are going away as being obsolete now.
>> Switch to the preferred irq_domain_create_*() ones. Those differ in the
>> node parameter: They take more generic struct fwnode_handle instead of
>> struct device_node. Therefore, of_fwnode_handle() is added around the
>> original parameter.
>>
>> Note some of the users can likely use dev->fwnode directly instead of
>> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
>> guaranteed to be set for all, so this has to be investigated on case to
>> case basis (by people who can actually test with the HW).
>
> ...
>
>> /**
>> * @first:
>> *
>> - * Required for static IRQ allocation. If set, irq_domain_add_simple()
>
>> - * will allocate and map all IRQs during initialization.
>
> Can we leave this untouched? The new name will make the string 81 characters
> long and I don't think we care about that, on the pros side it will reduce
> a churn in this patch.

Sure -- fixed.

thanks,
--
js
suse labs