Re: [PATCH v2 21/57] irqdomain: irqchip: Switch to irq_domain_create_*()

Linus Walleij
2025-03-20T08:25:30Z

On Wed, Mar 19, 2025 at 10:31 AM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:

> irq_domain_add_*() interfaces are going away as being obsolete now.
> Switch to the preferred irq_domain_create_*() ones. Those differ in the
> node parameter: They take more generic struct fwnode_handle instead of
> struct device_node. Therefore, of_fwnode_handle() is added around the
> original parameter.
>
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>

There are some stray whitespace changes which are distracting,
but as things are, there is
Documentation/process/4.Coding.rst
saying:

It is natural to fix the style of a piece of code while working
on it for other reasons, but coding style changes should not be made for
their own sake.

...and you are working on the code for other reasons so I
read it like this is actually OK.

(Written mostly to forestall any similar comments.)

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij