Re: [PATCH v2 05/57] irqdomain: cdx: Switch to of_fwnode_handle()

Jiri Slaby
2025-04-07T07:09:01Z

@cdx maintainers: if you have not read 00/57 [1], please route this
through your tree.

[1] https://lore.kernel.org/all/20250319092951.37667-1-jirislaby@kernel.org/

Thanks.

On 19. 03. 25, 10:28, Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is irqdomain's reimplementation of the "officially"
> defined of_fwnode_handle(). The former is in the process of being
> removed, so use the latter instead.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Nipun Gupta <nipun.gupta@amd.com>
> Cc: Nikhil Agarwal <nikhil.agarwal@amd.com>
> ---
> drivers/cdx/cdx_msi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cdx/cdx_msi.c b/drivers/cdx/cdx_msi.c
> index 06d723978232..3388a5d1462c 100644
> --- a/drivers/cdx/cdx_msi.c
> +++ b/drivers/cdx/cdx_msi.c
> @@ -165,7 +165,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)
> struct device_node *parent_node;
> struct irq_domain *parent;
>
> - fwnode_handle = of_node_to_fwnode(np);
> + fwnode_handle = of_fwnode_handle(np);
>
> parent_node = of_parse_phandle(np, "msi-map", 1);
> if (!parent_node) {
> @@ -173,7 +173,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)
> return NULL;
> }
>
> - parent = irq_find_matching_fwnode(of_node_to_fwnode(parent_node), DOMAIN_BUS_NEXUS);
> + parent = irq_find_matching_fwnode(of_fwnode_handle(parent_node), DOMAIN_BUS_NEXUS);
> if (!parent || !msi_get_domain_info(parent)) {
> dev_err(dev, "unable to locate ITS domain\n");
> return NULL;

--
js
suse labs