Re: [PATCH v2 31/57] irqdomain: platform/x86: Switch to irq_domain_create_linear()

Ilpo Järvinen
2025-03-21T15:51:51Z

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

On Wed, 19 Mar 2025, Jiri Slaby (SUSE) wrote:

> irq_domain_add_linear() is going away as being obsolete now. Switch to
> the preferred irq_domain_create_linear(). That differs in the first
> parameter: It takes more generic struct fwnode_handle instead of struct
> device_node. Therefore, of_fwnode_handle() is added around the
> parameter.
>
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Corentin Chary <corentin.chary@gmail.com>
> Cc: "Luke D. Jones" <luke@ljones.dev>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org

I've applied this now to review-ilpo-next, but I had to remove lots of
unnecessary details from the commit message as here the first arg is NULL.

I'd also prefer to not have long is of Ccs before --- line for changes
like this (more understandable if it's some problem/fix related
submission). Wouldn't they work also if Cc: lines are put below ---
or is it that the tools fail to preserve that at some point?

> ---
> drivers/platform/x86/asus-tf103c-dock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-tf103c-dock.c b/drivers/platform/x86/asus-tf103c-dock.c
> index ca4670d0dc67..f09a3fc6524a 100644
> --- a/drivers/platform/x86/asus-tf103c-dock.c
> +++ b/drivers/platform/x86/asus-tf103c-dock.c
> @@ -856,7 +856,7 @@ static int tf103c_dock_probe(struct i2c_client *client)
> /* 5. Setup irqchip for touchpad IRQ pass-through */
> dock->tp_irqchip.name = KBUILD_MODNAME;
>
> - dock->tp_irq_domain = irq_domain_add_linear(NULL, 1, &irq_domain_simple_ops, NULL);
> + dock->tp_irq_domain = irq_domain_create_linear(NULL, 1, &irq_domain_simple_ops, NULL);
> if (!dock->tp_irq_domain)
> return -ENOMEM;
>
>

--
i.