[PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Konrad Dybcio]

Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>

No external dependencies

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (5):
      arm64: dts: qcom: msm8916: Add Venus OPP table
      arm64: dts: qcom: msm8996: Add Venus OPP table
      arm64: dts: qcom: msm8998: Add Venus OPP table
      arm64: dts: qcom: sdm630: Add Venus OPP table
      arm64: dts: qcom: sdm845: Fix Venus OPP entries

 arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 ++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 39 ++++++++++++++++++++++++++++-------
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 30 +++++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sdm630.dtsi  | 35 +++++++++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sdm845.dtsi  | 24 ++++++++++-----------
 5 files changed, 128 insertions(+), 20 deletions(-)
---
base-commit: 2a628f951ed54c30a232230b5b58349d2a8dbb11
change-id: 20250531-topic-venus_opp_arm64-378e98bf6071

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

[PATCH 1/5] arm64: dts: qcom: msm8916: Add Venus OPP table

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the DVFS levels explicitly.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index de9fdc0dfc5f9b223ee252b80fc18d45c9bb6582..6749facabdc512879e17061b03d0ed9e41671642 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1827,6 +1827,7 @@ venus: video-codec@1d00000 {
 			reg = <0x01d00000 0xff000>;
 			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&gcc VENUS_GDSC>;
+			operating-points-v2 = <&venus_opp_table>;
 			clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>,
 				 <&gcc GCC_VENUS0_AHB_CLK>,
 				 <&gcc GCC_VENUS0_AXI_CLK>;
@@ -1835,6 +1836,25 @@ venus: video-codec@1d00000 {
 			memory-region = <&venus_mem>;
 			status = "disabled";
 
+			venus_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					required-opps = <&rpmpd_opp_svs_soc>;
+				};
+
+				opp-160000000 {
+					opp-hz = /bits/ 64 <160000000>;
+					required-opps = <&rpmpd_opp_nom>;
+				};
+
+				opp-228570000 {
+					opp-hz = /bits/ 64 <228570000>;
+					required-opps = <&rpmpd_opp_super_turbo>;
+				};
+			};
+
 			video-decoder {
 				compatible = "venus-decoder";
 			};

-- 
2.49.0

[PATCH 2/5] arm64: dts: qcom: msm8996: Add Venus OPP table

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the DVFS levels explicitly.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 39 ++++++++++++++++++++++++++++-------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index ede851fbf628428f5740ca8add65ffc05360cc62..7bb34e60739b2e561ff5fd9e19a6e617fb601a60 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -491,27 +491,25 @@ rpmpd: power-controller {
 					rpmpd_opp_table: opp-table {
 						compatible = "operating-points-v2";
 
-						rpmpd_opp1: opp1 {
+						rpmpd_opp_ret: opp1 {
 							opp-level = <1>;
 						};
 
-						rpmpd_opp2: opp2 {
-							opp-level = <2>;
-						};
+						/* No SVS_KRAIT/SVS_LOW */
 
-						rpmpd_opp3: opp3 {
+						rpmpd_opp_svs_soc: opp3 {
 							opp-level = <3>;
 						};
 
-						rpmpd_opp4: opp4 {
+						rpmpd_opp_nom: opp4 {
 							opp-level = <4>;
 						};
 
-						rpmpd_opp5: opp5 {
+						rpmpd_opp_turbo: opp5 {
 							opp-level = <5>;
 						};
 
-						rpmpd_opp6: opp6 {
+						rpmpd_opp_super_turbo: opp6 {
 							opp-level = <6>;
 						};
 					};
@@ -2333,6 +2331,7 @@ venus: video-codec@c00000 {
 			reg = <0x00c00000 0xff000>;
 			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&mmcc VENUS_GDSC>;
+			operating-points-v2 = <&venus_opp_table>;
 			clocks = <&mmcc VIDEO_CORE_CLK>,
 				 <&mmcc VIDEO_AHB_CLK>,
 				 <&mmcc VIDEO_AXI_CLK>,
@@ -2364,6 +2363,30 @@ venus: video-codec@c00000 {
 			memory-region = <&venus_mem>;
 			status = "disabled";
 
+			venus_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-75000000 {
+					opp-hz = /bits/ 64 <75000000>;
+					required-opps = <&rpmpd_opp_svs_soc>;
+				};
+
+				opp-150000000 {
+					opp-hz = /bits/ 64 <150000000>;
+					required-opps = <&rpmpd_opp_svs_soc>;
+				};
+
+				opp-346666667 {
+					opp-hz = /bits/ 64 <346666667>;
+					required-opps = <&rpmpd_opp_nom>;
+				};
+
+				opp-520000000 {
+					opp-hz = /bits/ 64 <520000000>;
+					required-opps = <&rpmpd_opp_turbo>;
+				};
+			};
+
 			video-decoder {
 				compatible = "venus-decoder";
 				clocks = <&mmcc VIDEO_SUBCORE0_CLK>;

-- 
2.49.0

[PATCH 3/5] arm64: dts: qcom: msm8998: Add Venus OPP table

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the DVFS levels explicitly.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 58cee37cb8eecbdd43a474d548dcae1606aba6c7..76691e5b2608f33fa58b39ea338e41172a9e111d 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -3160,6 +3160,7 @@ venus: video-codec@cc00000 {
 			reg = <0x0cc00000 0xff000>;
 			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&mmcc VIDEO_TOP_GDSC>;
+			operating-points-v2 = <&venus_opp_table>;
 			clocks = <&mmcc VIDEO_CORE_CLK>,
 				 <&mmcc VIDEO_AHB_CLK>,
 				 <&mmcc VIDEO_AXI_CLK>,
@@ -3188,6 +3189,35 @@ venus: video-codec@cc00000 {
 			memory-region = <&venus_mem>;
 			status = "disabled";
 
+			venus_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-200000000 {
+					opp-hz = /bits/ 64 <200000000>;
+					required-opps = <&rpmpd_opp_low_svs>;
+				};
+
+				opp-269330000 {
+					opp-hz = /bits/ 64 <269330000>;
+					required-opps = <&rpmpd_opp_svs>;
+				};
+
+				opp-355200000 {
+					opp-hz = /bits/ 64 <355200000>;
+					required-opps = <&rpmpd_opp_svs_plus>;
+				};
+
+				opp-444000000 {
+					opp-hz = /bits/ 64 <444000000>;
+					required-opps = <&rpmpd_opp_nom>;
+				};
+
+				opp-533000000 {
+					opp-hz = /bits/ 64 <533000000>;
+					required-opps = <&rpmpd_opp_turbo>;
+				};
+			};
+
 			video-decoder {
 				compatible = "venus-decoder";
 				clocks = <&mmcc VIDEO_SUBCORE0_CLK>;

-- 
2.49.0

[PATCH 4/5] arm64: dts: qcom: sdm630: Add Venus OPP table

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the DVFS levels explicitly.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm630.dtsi | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 8b1a45a4e56ed1ae02e5bb6e78ca6255d87add1c..445cab2ddb12ebb572788030a7913cb77e9f7f78 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -2202,8 +2202,43 @@ venus: video-codec@cc00000 {
 				 <&mmss_smmu 0x431>;
 			memory-region = <&venus_region>;
 			power-domains = <&mmcc VENUS_GDSC>;
+			operating-points-v2 = <&venus_opp_table>;
 			status = "disabled";
 
+			venus_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-133330000 {
+					opp-hz = /bits/ 64 <133330000>;
+					required-opps = <&rpmpd_opp_low_svs>;
+				};
+
+				opp-269330000 {
+					opp-hz = /bits/ 64 <269330000>;
+					required-opps = <&rpmpd_opp_svs>;
+				};
+
+				opp-320000000 {
+					opp-hz = /bits/ 64 <320000000>;
+					required-opps = <&rpmpd_opp_svs_plus>;
+				};
+
+				opp-404000000 {
+					opp-hz = /bits/ 64 <404000000>;
+					required-opps = <&rpmpd_opp_nom>;
+				};
+
+				opp-441600000 {
+					opp-hz = /bits/ 64 <441600000>;
+					required-opps = <&rpmpd_opp_nom_plus>;
+				};
+
+				opp-518400000 {
+					opp-hz = /bits/ 64 <518400000>;
+					required-opps = <&rpmpd_opp_turbo>;
+				};
+			};
+
 			video-decoder {
 				compatible = "venus-decoder";
 				clocks = <&mmcc VIDEO_SUBCORE0_CLK>;

-- 
2.49.0

[PATCH 5/5] arm64: dts: qcom: sdm845: Fix Venus OPP entries

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Make them aligned with both the Venus and clock drivers. The existing
ones seem to have been based on data for the non-final SKU.

Take the liberty to move the opp table subnode to retain alphabetical
order while at it.

Fixes: 137154871cf4 ("arm64: dts: qcom: sdm845: Add OPP tables and power-domains for venus")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 3bc8471c658bda987d6fcff3359d63b367148e89..7d22ecb908cd4dd792a36beaee0ede061c5abd0f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4254,14 +4254,6 @@ venus: video-codec@aa00000 {
 
 			status = "disabled";
 
-			video-core0 {
-				compatible = "venus-decoder";
-			};
-
-			video-core1 {
-				compatible = "venus-encoder";
-			};
-
 			venus_opp_table: opp-table {
 				compatible = "operating-points-v2";
 
@@ -4275,13 +4267,13 @@ opp-200000000 {
 					required-opps = <&rpmhpd_opp_low_svs>;
 				};
 
-				opp-320000000 {
-					opp-hz = /bits/ 64 <320000000>;
+				opp-330000000 {
+					opp-hz = /bits/ 64 <330000000>;
 					required-opps = <&rpmhpd_opp_svs>;
 				};
 
-				opp-380000000 {
-					opp-hz = /bits/ 64 <380000000>;
+				opp-404000000 {
+					opp-hz = /bits/ 64 <404000000>;
 					required-opps = <&rpmhpd_opp_svs_l1>;
 				};
 
@@ -4295,6 +4287,14 @@ opp-533000097 {
 					required-opps = <&rpmhpd_opp_turbo>;
 				};
 			};
+
+			video-core0 {
+				compatible = "venus-decoder";
+			};
+
+			video-core1 {
+				compatible = "venus-encoder";
+			};
 		};
 
 		videocc: clock-controller@ab00000 {

-- 
2.49.0

Re: [PATCH 5/5] arm64: dts: qcom: sdm845: Fix Venus OPP entries

[Dmitry Baryshkov]

On Sat, May 31, 2025 at 02:27:23PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Make them aligned with both the Venus and clock drivers. The existing
> ones seem to have been based on data for the non-final SKU.
> 
> Take the liberty to move the opp table subnode to retain alphabetical
> order while at it.
> 
> Fixes: 137154871cf4 ("arm64: dts: qcom: sdm845: Add OPP tables and power-domains for venus")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 3bc8471c658bda987d6fcff3359d63b367148e89..7d22ecb908cd4dd792a36beaee0ede061c5abd0f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4254,14 +4254,6 @@ venus: video-codec@aa00000 {
>  
>  			status = "disabled";
>  
> -			video-core0 {
> -				compatible = "venus-decoder";
> -			};
> -
> -			video-core1 {
> -				compatible = "venus-encoder";
> -			};
> -
>  			venus_opp_table: opp-table {
>  				compatible = "operating-points-v2";
>  
> @@ -4275,13 +4267,13 @@ opp-200000000 {
>  					required-opps = <&rpmhpd_opp_low_svs>;
>  				};
>  
> -				opp-320000000 {
> -					opp-hz = /bits/ 64 <320000000>;
> +				opp-330000000 {
> +					opp-hz = /bits/ 64 <330000000>;
>  					required-opps = <&rpmhpd_opp_svs>;
>  				};
>  
> -				opp-380000000 {
> -					opp-hz = /bits/ 64 <380000000>;
> +				opp-404000000 {
> +					opp-hz = /bits/ 64 <404000000>;
>  					required-opps = <&rpmhpd_opp_svs_l1>;
>  				};
>  
> @@ -4295,6 +4287,14 @@ opp-533000097 {
>  					required-opps = <&rpmhpd_opp_turbo>;
>  				};
>  			};
> +
> +			video-core0 {
> +				compatible = "venus-decoder";
> +			};
> +
> +			video-core1 {
> +				compatible = "venus-encoder";
> +			};

We don't need these nodes anymore. Please split into two patches: one
fixing the OPP table and another one, removing subnodes.

>  		};
>  
>  		videocc: clock-controller@ab00000 {
> 
> -- 
> 2.49.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH 4/5] arm64: dts: qcom: sdm630: Add Venus OPP table

[Dmitry Baryshkov]

On Sat, May 31, 2025 at 02:27:22PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the DVFS levels explicitly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm630.dtsi | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 2/5] arm64: dts: qcom: msm8996: Add Venus OPP table

[Dmitry Baryshkov]

On Sat, May 31, 2025 at 02:27:20PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the DVFS levels explicitly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 39 ++++++++++++++++++++++++++++-------
>  1 file changed, 31 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index ede851fbf628428f5740ca8add65ffc05360cc62..7bb34e60739b2e561ff5fd9e19a6e617fb601a60 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -491,27 +491,25 @@ rpmpd: power-controller {
>  					rpmpd_opp_table: opp-table {
>  						compatible = "operating-points-v2";
>  
> -						rpmpd_opp1: opp1 {
> +						rpmpd_opp_ret: opp1 {
>  							opp-level = <1>;
>  						};
>  
> -						rpmpd_opp2: opp2 {
> -							opp-level = <2>;
> -						};
> +						/* No SVS_KRAIT/SVS_LOW */
>  
> -						rpmpd_opp3: opp3 {
> +						rpmpd_opp_svs_soc: opp3 {
>  							opp-level = <3>;
>  						};
>  
> -						rpmpd_opp4: opp4 {
> +						rpmpd_opp_nom: opp4 {
>  							opp-level = <4>;
>  						};
>  
> -						rpmpd_opp5: opp5 {
> +						rpmpd_opp_turbo: opp5 {
>  							opp-level = <5>;
>  						};
>  
> -						rpmpd_opp6: opp6 {
> +						rpmpd_opp_super_turbo: opp6 {

These renames deserve a phrase in the commit message. With that fixed:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


>  							opp-level = <6>;
>  						};
>  					};
> @@ -2333,6 +2331,7 @@ venus: video-codec@c00000 {
>  			reg = <0x00c00000 0xff000>;
>  			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
>  			power-domains = <&mmcc VENUS_GDSC>;
> +			operating-points-v2 = <&venus_opp_table>;
>  			clocks = <&mmcc VIDEO_CORE_CLK>,
>  				 <&mmcc VIDEO_AHB_CLK>,
>  				 <&mmcc VIDEO_AXI_CLK>,
> @@ -2364,6 +2363,30 @@ venus: video-codec@c00000 {
>  			memory-region = <&venus_mem>;
>  			status = "disabled";
>  
> +			venus_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-75000000 {
> +					opp-hz = /bits/ 64 <75000000>;
> +					required-opps = <&rpmpd_opp_svs_soc>;
> +				};
> +
> +				opp-150000000 {
> +					opp-hz = /bits/ 64 <150000000>;
> +					required-opps = <&rpmpd_opp_svs_soc>;
> +				};
> +
> +				opp-346666667 {
> +					opp-hz = /bits/ 64 <346666667>;
> +					required-opps = <&rpmpd_opp_nom>;
> +				};
> +
> +				opp-520000000 {
> +					opp-hz = /bits/ 64 <520000000>;
> +					required-opps = <&rpmpd_opp_turbo>;
> +				};
> +			};
> +
>  			video-decoder {
>  				compatible = "venus-decoder";
>  				clocks = <&mmcc VIDEO_SUBCORE0_CLK>;
> 
> -- 
> 2.49.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/5] arm64: dts: qcom: msm8916: Add Venus OPP table

[Dmitry Baryshkov]

On Sat, May 31, 2025 at 02:27:19PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the DVFS levels explicitly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 3/5] arm64: dts: qcom: msm8998: Add Venus OPP table

[Dmitry Baryshkov]

On Sat, May 31, 2025 at 02:27:21PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the DVFS levels explicitly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Stephan Gerhold]

On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>
> 
> No external dependencies
> 

Are you sure?

> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (5):
>       arm64: dts: qcom: msm8916: Add Venus OPP table
>       arm64: dts: qcom: msm8996: Add Venus OPP table
>       arm64: dts: qcom: msm8998: Add Venus OPP table
>       arm64: dts: qcom: sdm630: Add Venus OPP table

None of these platforms has a power domain that supports performance
states specified in the venus node of the DT, and the venus GDSC does
not have any parent either. I think you will need to update the venus
bindings and add

	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },

for all these in the venus driver (plus backwards compat if not already
there). And then add that power domain additionally in the DT.

This series is also introducing new dtbs_check failures :/

qcom/apq8016-sbc.dtb: video-codec@1d00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                               
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#         
qcom/apq8096-db820c.dtb: video-codec@c00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                             
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#     
qcom/msm8998-lenovo-miix-630.dtb: video-codec@cc00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                   
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#       

>       arm64: dts: qcom: sdm845: Fix Venus OPP entries

This one has .opp_pmdomain and "cx" in the bindings, so it's probably
fine (didn't check if the current OPPs are really wrong).

Thanks,
Stephan

Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Rob Herring (Arm)]

On Sat, 31 May 2025 14:27:18 +0200, Konrad Dybcio wrote:
> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>
> 
> No external dependencies
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (5):
>       arm64: dts: qcom: msm8916: Add Venus OPP table
>       arm64: dts: qcom: msm8996: Add Venus OPP table
>       arm64: dts: qcom: msm8998: Add Venus OPP table
>       arm64: dts: qcom: sdm630: Add Venus OPP table
>       arm64: dts: qcom: sdm845: Fix Venus OPP entries
> 
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 20 ++++++++++++++++++
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 39 ++++++++++++++++++++++++++++-------
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 30 +++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sdm630.dtsi  | 35 +++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi  | 24 ++++++++++-----------
>  5 files changed, 128 insertions(+), 20 deletions(-)
> ---
> base-commit: 2a628f951ed54c30a232230b5b58349d2a8dbb11
> change-id: 20250531-topic-venus_opp_arm64-378e98bf6071
> 
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 2a628f951ed54c30a232230b5b58349d2a8dbb11

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250531-topic-venus_opp_arm64-v1-0-54c6c417839f@oss.qualcomm.com:

arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-j3ltetw.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-e5.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-rossa.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/apq8016-sbc-d3-camera-mezzanine.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dtb: video-codec@cc00000 (qcom,msm8998-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-grandmax.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-e7.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-yiming-uz801v3.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-lg-c50.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-lg-m216.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb: video-codec@c00000 (qcom,msm8996-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-thwc-uf896.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt86518.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt86528.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#
arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dtb: video-codec@1d00000 (qcom,msm8916-venus): Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#

Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Konrad Dybcio]

On 6/2/25 10:09 AM, Stephan Gerhold wrote:
> On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
>> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>
>>
>> No external dependencies
>>
> 
> Are you sure?
> 
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>> Konrad Dybcio (5):
>>       arm64: dts: qcom: msm8916: Add Venus OPP table
>>       arm64: dts: qcom: msm8996: Add Venus OPP table
>>       arm64: dts: qcom: msm8998: Add Venus OPP table
>>       arm64: dts: qcom: sdm630: Add Venus OPP table
> 
> None of these platforms has a power domain that supports performance
> states specified in the venus node of the DT, and the venus GDSC does
> not have any parent either. I think you will need to update the venus
> bindings and add
> 
> 	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },
> 
> for all these in the venus driver (plus backwards compat if not already
> there). And then add that power domain additionally in the DT.

Making use of these tables would certainly be welcome.. This patchset
was aimed at pushing them to fdt, so that we can debate dropping the
hardcoded values in the driver in the future.

> 
> This series is also introducing new dtbs_check failures :/
> 
> qcom/apq8016-sbc.dtb: video-codec@1d00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                               
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#         
> qcom/apq8096-db820c.dtb: video-codec@c00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                             
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#     
> qcom/msm8998-lenovo-miix-630.dtb: video-codec@cc00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                   
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#       

Yikes, I didn't check as I assumed the bindings would be common - but
this always seems to bite.

> 
>>       arm64: dts: qcom: sdm845: Fix Venus OPP entries
> 
> This one has .opp_pmdomain and "cx" in the bindings, so it's probably
> fine (didn't check if the current OPPs are really wrong).
> 
> Thanks,
> Stephan

Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Konrad Dybcio]

On 6/11/25 10:43 PM, Konrad Dybcio wrote:
> On 6/2/25 10:09 AM, Stephan Gerhold wrote:
>> On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
>>> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>
>>>
>>> No external dependencies
>>>
>>
>> Are you sure?
>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> ---
>>> Konrad Dybcio (5):
>>>       arm64: dts: qcom: msm8916: Add Venus OPP table
>>>       arm64: dts: qcom: msm8996: Add Venus OPP table
>>>       arm64: dts: qcom: msm8998: Add Venus OPP table
>>>       arm64: dts: qcom: sdm630: Add Venus OPP table
>>
>> None of these platforms has a power domain that supports performance
>> states specified in the venus node of the DT, and the venus GDSC does
>> not have any parent either. I think you will need to update the venus
>> bindings and add
>>
>> 	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },
>>
>> for all these in the venus driver (plus backwards compat if not already
>> there). And then add that power domain additionally in the DT.
> 
> Making use of these tables would certainly be welcome.. This patchset
> was aimed at pushing them to fdt, so that we can debate dropping the
> hardcoded values in the driver in the future.

I don't think we can just plug them in to the driver right now, as
it would also happen to break backwards compat (since
devm_pm_domain_attach_list() seems to not be particularly happy about
missing resources) - though arguments can be made both ways: "it
could have never *really* worked" vs "don't poke at the old driver for
old hardware too much, as it's gonna break"

Konrad

Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Stephan Gerhold]

On Wed, Jun 11, 2025 at 10:46:17PM +0200, Konrad Dybcio wrote:
> On 6/11/25 10:43 PM, Konrad Dybcio wrote:
> > On 6/2/25 10:09 AM, Stephan Gerhold wrote:
> >> On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
> >>> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@quicinc.com>
> >>>
> >>> No external dependencies
> >>>
> >>
> >> Are you sure?
> >>
> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>> ---
> >>> Konrad Dybcio (5):
> >>>       arm64: dts: qcom: msm8916: Add Venus OPP table
> >>>       arm64: dts: qcom: msm8996: Add Venus OPP table
> >>>       arm64: dts: qcom: msm8998: Add Venus OPP table
> >>>       arm64: dts: qcom: sdm630: Add Venus OPP table
> >>
> >> None of these platforms has a power domain that supports performance
> >> states specified in the venus node of the DT, and the venus GDSC does
> >> not have any parent either. I think you will need to update the venus
> >> bindings and add
> >>
> >> 	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },
> >>
> >> for all these in the venus driver (plus backwards compat if not already
> >> there). And then add that power domain additionally in the DT.
> > 
> > Making use of these tables would certainly be welcome.. This patchset
> > was aimed at pushing them to fdt, so that we can debate dropping the
> > hardcoded values in the driver in the future.
> 
> I don't think we can just plug them in to the driver right now, as
> it would also happen to break backwards compat (since
> devm_pm_domain_attach_list() seems to not be particularly happy about
> missing resources) - though arguments can be made both ways: "it
> could have never *really* worked" vs "don't poke at the old driver for
> old hardware too much, as it's gonna break"
> 

You could just make it ignore the returned error for the call to

	ret = devm_pm_domain_attach_list(dev, &opp_pd_data, &core->opp_pmdomain);

? Perhaps with some extra flag that only enables that for the older
platforms.

I suppose having the DT complete is also helpful, even without the
driver changes. But at the end this would be untested "dead" properties
that may turn out being subtly wrong when someone tries to actually
enable it. So having it properly enabled and tested would be good,
especially since the required changes don't sound too massive and
intrusive to me.

Thanks,
Stephan