The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bin Liu <b-liu@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
	balbif@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Date: Wed, 20 Jan 2016 11:56:34 +0100	[thread overview]
Message-ID: <1749004.q1rSF7t8cz@wuerfel> (raw)

The phy-am335x driver accidentally selects 'USB_COMMON', which is
not correct as that symbol should indicate whether USB host or
target mode is enabled, but it might not:

warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))

This changes the 'select' into 'depends on', as it should have
been initially.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index c6904742e2aa..29f063c59e1a 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -63,10 +63,10 @@ config AM335X_CONTROL_USB
 config AM335X_PHY_USB
 	tristate "AM335x USB PHY Driver"
 	depends on ARM || COMPILE_TEST
+	depends on USB_COMMON
 	select USB_PHY
 	select AM335X_CONTROL_USB
 	select NOP_USB_XCEIV
-	select USB_COMMON
 	help
 	  This driver provides PHY support for that phy which part for the
 	  AM335x SoC.

             reply	other threads:[~2016-01-20 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 10:56 Arnd Bergmann [this message]
2016-01-20 18:08 ` [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Bin Liu
2016-02-03 17:54   ` Felipe Balbi
2016-02-03 21:08     ` Arnd Bergmann
2016-02-03 22:04       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1749004.q1rSF7t8cz@wuerfel \
    --to=arnd@arndb.de \
    --cc=b-liu@ti.com \
    --cc=balbi@ti.com \
    --cc=balbif@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox