Re: [PATCH] riscv: defconfig: run savedefconfig to reorder it

Alexandre Ghiti
2025-06-12T08:37:19Z

Hi Yixun,

On 6/11/25 16:56, Yixun Lan wrote:
> Changes to defconfig should be always updated via 'make
> savedefconfig', run this command to make it aligned again.
>
> This will ease the effort of reviewing changes of defconfig
> in the future.
>
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
> Update PDMA config bring in unnecessary changes[1], let's fix
> it by run savedefconfig first.

It would be easier if this patch was part of the PDMA series since the
last patch will depend on it: @Guodong can you integrate this patch to
your next revision of your patchset?

Thanks,

Alex

>
> This patch is based on top of tag 6.16-rc1.
>
> Link: https://lore.kernel.org/all/20250611134859-GYA125008@gentoo/ [1]
> ---
> arch/riscv/configs/defconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index fe8bd8afb4183ce871020fb2992a21a13bccbc87..37c98c0f98ffc0ee9d021e4d07aa37a27d342f7a 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -134,6 +134,7 @@ CONFIG_MACB=y
> CONFIG_E1000E=y
> CONFIG_R8169=y
> CONFIG_STMMAC_ETH=m
> +CONFIG_DWMAC_THEAD=m
> CONFIG_MICREL_PHY=y
> CONFIG_MICROSEMI_PHY=y
> CONFIG_MOTORCOMM_PHY=y
> @@ -151,7 +152,6 @@ CONFIG_HW_RANDOM_JH7110=m
> CONFIG_I2C=y
> CONFIG_I2C_CHARDEV=m
> CONFIG_I2C_DESIGNWARE_CORE=y
> -CONFIG_I2C_DESIGNWARE_PLATFORM=y
> CONFIG_I2C_MV64XXX=m
> CONFIG_SPI=y
> CONFIG_SPI_CADENCE_QUADSPI=m
> @@ -159,11 +159,11 @@ CONFIG_SPI_PL022=m
> CONFIG_SPI_SIFIVE=y
> CONFIG_SPI_SUN6I=y
> # CONFIG_PTP_1588_CLOCK is not set
> +CONFIG_PINCTRL_TH1520=y
> CONFIG_PINCTRL_SOPHGO_CV1800B=y
> CONFIG_PINCTRL_SOPHGO_CV1812H=y
> CONFIG_PINCTRL_SOPHGO_SG2000=y
> CONFIG_PINCTRL_SOPHGO_SG2002=y
> -CONFIG_PINCTRL_TH1520=y
> CONFIG_GPIO_DWAPB=y
> CONFIG_GPIO_SIFIVE=y
> CONFIG_GPIO_SPACEMIT_K1=y
> @@ -240,7 +240,6 @@ CONFIG_RTC_DRV_SUN6I=y
> CONFIG_DMADEVICES=y
> CONFIG_DMA_SUN6I=m
> CONFIG_DW_AXI_DMAC=y
> -CONFIG_DWMAC_THEAD=m
> CONFIG_VIRTIO_PCI=y
> CONFIG_VIRTIO_BALLOON=y
> CONFIG_VIRTIO_INPUT=y
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250611-01-riscv-defconfig-7f90f73d283d
>
> Best regards,