Re: Please pull from 'for_paulus' branch of powerpc

Kumar Gala
2006-05-04T22:11:05Z

On May 4, 2006, at 5:09 PM, Segher Boessenkool wrote:

> Hi Kumar,
>
>> +static int ppc_panic_event(struct notifier_block *this,
>> + unsigned long event, void *ptr)
>> +{
>> + ppc_md.panic((char *)ptr); /* May not return */
>> + return NOTIFY_DONE;
>> +}
>
> Lose the redundant pointer cast while you're there please?
>
>> void __init setup_arch(char **cmdline_p)
>> {
>> extern void do_init_bootmem(void);
>> + extern void setup_panic(void);
>
> Can those two go into a header file please?

any suggestions on which header?