From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Hans de Goede <hansg@kernel.org>,
Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Tero Kristo <tero.kristo@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel-uncore-freq: avoid non-literal format string
Date: Fri, 13 Jun 2025 11:48:21 +0300 [thread overview]
Message-ID: <174980450175.1640.12062242383746628445.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250610093459.2646337-1-arnd@kernel.org>
On Tue, 10 Jun 2025 11:34:55 +0200, Arnd Bergmann wrote:
> Using a string variable in place of a format string causes a W=1 build warning:
>
> drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c:61:40: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
> 61 | length += sysfs_emit_at(buf, length, agent_name[agent]);
> | ^~~~~~~~~~~~~~~~~
>
> Use the safer "%s" format string to print it instead.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/intel-uncore-freq: avoid non-literal format string
commit: 0c44b46f51a17baa7ab67de1464427116e9c4eaa
--
i.
prev parent reply other threads:[~2025-06-13 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:34 [PATCH] platform/x86/intel-uncore-freq: avoid non-literal format string Arnd Bergmann
2025-06-10 17:20 ` srinivas pandruvada
2025-06-13 8:48 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174980450175.1640.12062242383746628445.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tero.kristo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox