* [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
@ 2025-06-22 7:29 Alok Tiwari
2025-06-22 7:29 ` [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message Alok Tiwari
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Alok Tiwari @ 2025-06-22 7:29 UTC (permalink / raw)
To: hansg, ilpo.jarvinen, davthompson, michaelsh, vadimp,
platform-driver-x86
Cc: alok.a.tiwari, linux-kernel
This commit corrects several minor typographical errors in comments
and error messages across multiple Mellanox platform driver.
Fixed spelling of "thresholds", "region", "platform", "default",
and removed redundant spaces in comment strings and error logs.
These changes are cosmetic and do not affect runtime behavior.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
drivers/platform/mellanox/mlxreg-dpu.c | 2 +-
drivers/platform/mellanox/mlxreg-lc.c | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
index aae99adb29eb0..6264379d96907 100644
--- a/drivers/platform/mellanox/mlxbf-tmfifo.c
+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
@@ -1287,7 +1287,7 @@ static void mlxbf_tmfifo_get_cfg_mac(u8 *mac)
ether_addr_copy(mac, mlxbf_tmfifo_net_default_mac);
}
-/* Set TmFifo thresolds which is used to trigger interrupts. */
+/* Set TmFifo thresholds which is used to trigger interrupts. */
static void mlxbf_tmfifo_set_threshold(struct mlxbf_tmfifo *fifo)
{
u64 ctl;
diff --git a/drivers/platform/mellanox/mlxreg-dpu.c b/drivers/platform/mellanox/mlxreg-dpu.c
index 52260106a9f16..39f89c47144a2 100644
--- a/drivers/platform/mellanox/mlxreg-dpu.c
+++ b/drivers/platform/mellanox/mlxreg-dpu.c
@@ -483,7 +483,7 @@ static int mlxreg_dpu_config_init(struct mlxreg_dpu *mlxreg_dpu, void *regmap,
mlxreg_dpu->io_data,
sizeof(*mlxreg_dpu->io_data));
if (IS_ERR(mlxreg_dpu->io_regs)) {
- dev_err(dev, "Failed to create regio for client %s at bus %d at addr 0x%02x\n",
+ dev_err(dev, "Failed to create region for client %s at bus %d at addr 0x%02x\n",
data->hpdev.brdinfo->type, data->hpdev.nr,
data->hpdev.brdinfo->addr);
return PTR_ERR(mlxreg_dpu->io_regs);
diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c
index aee395bb48ae4..8eef3d990d1ae 100644
--- a/drivers/platform/mellanox/mlxreg-lc.c
+++ b/drivers/platform/mellanox/mlxreg-lc.c
@@ -57,9 +57,9 @@ enum mlxreg_lc_state {
* @dev: platform device;
* @lock: line card lock;
* @par_regmap: parent device regmap handle;
- * @data: pltaform core data;
+ * @data: platform core data;
* @io_data: register access platform data;
- * @led_data: LED platform data ;
+ * @led_data: LED platform data;
* @mux_data: MUX platform data;
* @led: LED device;
* @io_regs: register access device;
@@ -171,7 +171,7 @@ static int mlxreg_lc_chan[] = {
0x4e, 0x4f
};
-/* Defaul mux configuration. */
+/* Default mux configuration. */
static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
{
.chan_ids = mlxreg_lc_chan,
@@ -181,7 +181,7 @@ static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
},
};
-/* Defaul mux board info. */
+/* Default mux board info. */
static struct i2c_board_info mlxreg_lc_mux_brdinfo = {
I2C_BOARD_INFO("i2c-mux-mlxcpld", 0x32),
};
@@ -758,7 +758,7 @@ mlxreg_lc_config_init(struct mlxreg_lc *mlxreg_lc, void *regmap,
platform_device_register_resndata(dev, "mlxreg-io", data->hpdev.nr, NULL, 0,
mlxreg_lc->io_data, sizeof(*mlxreg_lc->io_data));
if (IS_ERR(mlxreg_lc->io_regs)) {
- dev_err(dev, "Failed to create regio for client %s at bus %d at addr 0x%02x\n",
+ dev_err(dev, "Failed to create region for client %s at bus %d at addr 0x%02x\n",
data->hpdev.brdinfo->type, data->hpdev.nr,
data->hpdev.brdinfo->addr);
err = PTR_ERR(mlxreg_lc->io_regs);
--
2.46.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message
2025-06-22 7:29 [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers Alok Tiwari
@ 2025-06-22 7:29 ` Alok Tiwari
2025-06-25 18:12 ` Vadim Pasternak
2025-06-24 20:17 ` [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers David Thompson
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Alok Tiwari @ 2025-06-22 7:29 UTC (permalink / raw)
To: hansg, ilpo.jarvinen, davthompson, michaelsh, vadimp,
platform-driver-x86
Cc: alok.a.tiwari, linux-kernel
change error log to use correct bus number from main_mux_devs
instead of cpld_devs.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/platform/mellanox/nvsw-sn2201.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/mellanox/nvsw-sn2201.c b/drivers/platform/mellanox/nvsw-sn2201.c
index db31c8bf22553..51504113c17ea 100644
--- a/drivers/platform/mellanox/nvsw-sn2201.c
+++ b/drivers/platform/mellanox/nvsw-sn2201.c
@@ -1181,7 +1181,7 @@ static int nvsw_sn2201_i2c_completion_notify(void *handle, int id)
if (!nvsw_sn2201->main_mux_devs->adapter) {
err = -ENODEV;
dev_err(nvsw_sn2201->dev, "Failed to get adapter for bus %d\n",
- nvsw_sn2201->cpld_devs->nr);
+ nvsw_sn2201->main_mux_devs->nr);
goto i2c_get_adapter_main_fail;
}
--
2.46.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
2025-06-22 7:29 [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers Alok Tiwari
2025-06-22 7:29 ` [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message Alok Tiwari
@ 2025-06-24 20:17 ` David Thompson
2025-06-24 20:50 ` Vadim Pasternak
2025-06-26 15:19 ` Ilpo Järvinen
3 siblings, 0 replies; 7+ messages in thread
From: David Thompson @ 2025-06-24 20:17 UTC (permalink / raw)
To: Alok Tiwari, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
Michael Shych, Vadim Pasternak,
platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Alok Tiwari <alok.a.tiwari@oracle.com>
> Sent: Sunday, June 22, 2025 3:29 AM
> To: hansg@kernel.org; ilpo.jarvinen@linux.intel.com; David Thompson
> <davthompson@nvidia.com>; Michael Shych <michaelsh@nvidia.com>; Vadim
> Pasternak <vadimp@nvidia.com>; platform-driver-x86@vger.kernel.org
> Cc: alok.a.tiwari@oracle.com; linux-kernel@vger.kernel.org
> Subject: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in
> Mellanox drivers
>
> This commit corrects several minor typographical errors in comments and error
> messages across multiple Mellanox platform driver.
> Fixed spelling of "thresholds", "region", "platform", "default", and removed
> redundant spaces in comment strings and error logs.
>
> These changes are cosmetic and do not affect runtime behavior.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
> drivers/platform/mellanox/mlxreg-dpu.c | 2 +-
> drivers/platform/mellanox/mlxreg-lc.c | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index aae99adb29eb0..6264379d96907 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -1287,7 +1287,7 @@ static void mlxbf_tmfifo_get_cfg_mac(u8 *mac)
> ether_addr_copy(mac, mlxbf_tmfifo_net_default_mac); }
>
> -/* Set TmFifo thresolds which is used to trigger interrupts. */
> +/* Set TmFifo thresholds which is used to trigger interrupts. */
> static void mlxbf_tmfifo_set_threshold(struct mlxbf_tmfifo *fifo) {
> u64 ctl;
> diff --git a/drivers/platform/mellanox/mlxreg-dpu.c
> b/drivers/platform/mellanox/mlxreg-dpu.c
> index 52260106a9f16..39f89c47144a2 100644
> --- a/drivers/platform/mellanox/mlxreg-dpu.c
> +++ b/drivers/platform/mellanox/mlxreg-dpu.c
> @@ -483,7 +483,7 @@ static int mlxreg_dpu_config_init(struct mlxreg_dpu
> *mlxreg_dpu, void *regmap,
> mlxreg_dpu->io_data,
> sizeof(*mlxreg_dpu-
> >io_data));
> if (IS_ERR(mlxreg_dpu->io_regs)) {
> - dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> + dev_err(dev, "Failed to create region for client %s at bus
> %d at
> +addr 0x%02x\n",
> data->hpdev.brdinfo->type, data->hpdev.nr,
> data->hpdev.brdinfo->addr);
> return PTR_ERR(mlxreg_dpu->io_regs); diff --git
> a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-
> lc.c
> index aee395bb48ae4..8eef3d990d1ae 100644
> --- a/drivers/platform/mellanox/mlxreg-lc.c
> +++ b/drivers/platform/mellanox/mlxreg-lc.c
> @@ -57,9 +57,9 @@ enum mlxreg_lc_state {
> * @dev: platform device;
> * @lock: line card lock;
> * @par_regmap: parent device regmap handle;
> - * @data: pltaform core data;
> + * @data: platform core data;
> * @io_data: register access platform data;
> - * @led_data: LED platform data ;
> + * @led_data: LED platform data;
> * @mux_data: MUX platform data;
> * @led: LED device;
> * @io_regs: register access device;
> @@ -171,7 +171,7 @@ static int mlxreg_lc_chan[] = {
> 0x4e, 0x4f
> };
>
> -/* Defaul mux configuration. */
> +/* Default mux configuration. */
> static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
> {
> .chan_ids = mlxreg_lc_chan,
> @@ -181,7 +181,7 @@ static struct mlxcpld_mux_plat_data
> mlxreg_lc_mux_data[] = {
> },
> };
>
> -/* Defaul mux board info. */
> +/* Default mux board info. */
> static struct i2c_board_info mlxreg_lc_mux_brdinfo = {
> I2C_BOARD_INFO("i2c-mux-mlxcpld", 0x32), }; @@ -758,7 +758,7 @@
> mlxreg_lc_config_init(struct mlxreg_lc *mlxreg_lc, void *regmap,
> platform_device_register_resndata(dev, "mlxreg-io", data-
> >hpdev.nr, NULL, 0,
> mlxreg_lc->io_data,
> sizeof(*mlxreg_lc->io_data));
> if (IS_ERR(mlxreg_lc->io_regs)) {
> - dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> + dev_err(dev, "Failed to create region for client %s at bus
> %d at
> +addr 0x%02x\n",
> data->hpdev.brdinfo->type, data->hpdev.nr,
> data->hpdev.brdinfo->addr);
> err = PTR_ERR(mlxreg_lc->io_regs);
> --
> 2.46.0
Reviewed-by: David Thompson <davthompson@nvidia.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
2025-06-22 7:29 [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers Alok Tiwari
2025-06-22 7:29 ` [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message Alok Tiwari
2025-06-24 20:17 ` [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers David Thompson
@ 2025-06-24 20:50 ` Vadim Pasternak
2025-06-25 12:36 ` Ilpo Järvinen
2025-06-26 15:19 ` Ilpo Järvinen
3 siblings, 1 reply; 7+ messages in thread
From: Vadim Pasternak @ 2025-06-24 20:50 UTC (permalink / raw)
To: Alok Tiwari, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
David Thompson, Michael Shych,
platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Alok Tiwari <alok.a.tiwari@oracle.com>
> Sent: Sunday, 22 June 2025 10:29
> To: hansg@kernel.org; ilpo.jarvinen@linux.intel.com; David Thompson
> <davthompson@nvidia.com>; Michael Shych <michaelsh@nvidia.com>;
> Vadim Pasternak <vadimp@nvidia.com>; platform-driver-x86@vger.kernel.org
> Cc: alok.a.tiwari@oracle.com; linux-kernel@vger.kernel.org
> Subject: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in
> Mellanox drivers
>
> This commit corrects several minor typographical errors in comments and
> error messages across multiple Mellanox platform driver.
> Fixed spelling of "thresholds", "region", "platform", "default", and removed
> redundant spaces in comment strings and error logs.
>
> These changes are cosmetic and do not affect runtime behavior.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>
> ---
> drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
> drivers/platform/mellanox/mlxreg-dpu.c | 2 +-
> drivers/platform/mellanox/mlxreg-lc.c | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index aae99adb29eb0..6264379d96907 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -1287,7 +1287,7 @@ static void mlxbf_tmfifo_get_cfg_mac(u8 *mac)
> ether_addr_copy(mac, mlxbf_tmfifo_net_default_mac); }
>
> -/* Set TmFifo thresolds which is used to trigger interrupts. */
> +/* Set TmFifo thresholds which is used to trigger interrupts. */
> static void mlxbf_tmfifo_set_threshold(struct mlxbf_tmfifo *fifo) {
> u64 ctl;
> diff --git a/drivers/platform/mellanox/mlxreg-dpu.c
> b/drivers/platform/mellanox/mlxreg-dpu.c
> index 52260106a9f16..39f89c47144a2 100644
> --- a/drivers/platform/mellanox/mlxreg-dpu.c
> +++ b/drivers/platform/mellanox/mlxreg-dpu.c
> @@ -483,7 +483,7 @@ static int mlxreg_dpu_config_init(struct mlxreg_dpu
> *mlxreg_dpu, void *regmap,
> mlxreg_dpu-
> >io_data,
> sizeof(*mlxreg_dpu-
> >io_data));
> if (IS_ERR(mlxreg_dpu->io_regs)) {
> - dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> + dev_err(dev, "Failed to create region for client %s at
> bus %d at
> +addr 0x%02x\n",
> data->hpdev.brdinfo->type, data->hpdev.nr,
> data->hpdev.brdinfo->addr);
> return PTR_ERR(mlxreg_dpu->io_regs); diff --git
> a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-
> lc.c
> index aee395bb48ae4..8eef3d990d1ae 100644
> --- a/drivers/platform/mellanox/mlxreg-lc.c
> +++ b/drivers/platform/mellanox/mlxreg-lc.c
> @@ -57,9 +57,9 @@ enum mlxreg_lc_state {
> * @dev: platform device;
> * @lock: line card lock;
> * @par_regmap: parent device regmap handle;
> - * @data: pltaform core data;
> + * @data: platform core data;
> * @io_data: register access platform data;
> - * @led_data: LED platform data ;
> + * @led_data: LED platform data;
> * @mux_data: MUX platform data;
> * @led: LED device;
> * @io_regs: register access device;
> @@ -171,7 +171,7 @@ static int mlxreg_lc_chan[] = {
> 0x4e, 0x4f
> };
>
> -/* Defaul mux configuration. */
> +/* Default mux configuration. */
> static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
> {
> .chan_ids = mlxreg_lc_chan,
> @@ -181,7 +181,7 @@ static struct mlxcpld_mux_plat_data
> mlxreg_lc_mux_data[] = {
> },
> };
>
> -/* Defaul mux board info. */
> +/* Default mux board info. */
> static struct i2c_board_info mlxreg_lc_mux_brdinfo = {
> I2C_BOARD_INFO("i2c-mux-mlxcpld", 0x32), }; @@ -758,7 +758,7
> @@ mlxreg_lc_config_init(struct mlxreg_lc *mlxreg_lc, void *regmap,
> platform_device_register_resndata(dev, "mlxreg-io", data-
> >hpdev.nr, NULL, 0,
> mlxreg_lc->io_data,
> sizeof(*mlxreg_lc->io_data));
> if (IS_ERR(mlxreg_lc->io_regs)) {
> - dev_err(dev, "Failed to create regio for client %s at bus
> %d at addr 0x%02x\n",
> + dev_err(dev, "Failed to create region for client %s at
> bus %d at
> +addr 0x%02x\n",
> data->hpdev.brdinfo->type, data->hpdev.nr,
> data->hpdev.brdinfo->addr);
> err = PTR_ERR(mlxreg_lc->io_regs);
> --
> 2.46.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
2025-06-24 20:50 ` Vadim Pasternak
@ 2025-06-25 12:36 ` Ilpo Järvinen
0 siblings, 0 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-06-25 12:36 UTC (permalink / raw)
To: Vadim Pasternak
Cc: Alok Tiwari, hansg@kernel.org, David Thompson, Michael Shych,
platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, 24 Jun 2025, Vadim Pasternak wrote:
> > -----Original Message-----
> > From: Alok Tiwari <alok.a.tiwari@oracle.com>
> > Sent: Sunday, 22 June 2025 10:29
> > To: hansg@kernel.org; ilpo.jarvinen@linux.intel.com; David Thompson
> > <davthompson@nvidia.com>; Michael Shych <michaelsh@nvidia.com>;
> > Vadim Pasternak <vadimp@nvidia.com>; platform-driver-x86@vger.kernel.org
> > Cc: alok.a.tiwari@oracle.com; linux-kernel@vger.kernel.org
> > Subject: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in
> > Mellanox drivers
> >
> > This commit corrects several minor typographical errors in comments and
> > error messages across multiple Mellanox platform driver.
> > Fixed spelling of "thresholds", "region", "platform", "default", and removed
> > redundant spaces in comment strings and error logs.
> >
> > These changes are cosmetic and do not affect runtime behavior.
> >
> > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>
> Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>
Okay folks, this was easy to review but what about the second patch which
does a real change to code (albeit only printing related)? Could somebody
review that as well? :-)
--
i.
> > ---
> > drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
> > drivers/platform/mellanox/mlxreg-dpu.c | 2 +-
> > drivers/platform/mellanox/mlxreg-lc.c | 10 +++++-----
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> > b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > index aae99adb29eb0..6264379d96907 100644
> > --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> > +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > @@ -1287,7 +1287,7 @@ static void mlxbf_tmfifo_get_cfg_mac(u8 *mac)
> > ether_addr_copy(mac, mlxbf_tmfifo_net_default_mac); }
> >
> > -/* Set TmFifo thresolds which is used to trigger interrupts. */
> > +/* Set TmFifo thresholds which is used to trigger interrupts. */
> > static void mlxbf_tmfifo_set_threshold(struct mlxbf_tmfifo *fifo) {
> > u64 ctl;
> > diff --git a/drivers/platform/mellanox/mlxreg-dpu.c
> > b/drivers/platform/mellanox/mlxreg-dpu.c
> > index 52260106a9f16..39f89c47144a2 100644
> > --- a/drivers/platform/mellanox/mlxreg-dpu.c
> > +++ b/drivers/platform/mellanox/mlxreg-dpu.c
> > @@ -483,7 +483,7 @@ static int mlxreg_dpu_config_init(struct mlxreg_dpu
> > *mlxreg_dpu, void *regmap,
> > mlxreg_dpu-
> > >io_data,
> > sizeof(*mlxreg_dpu-
> > >io_data));
> > if (IS_ERR(mlxreg_dpu->io_regs)) {
> > - dev_err(dev, "Failed to create regio for client %s at bus
> > %d at addr 0x%02x\n",
> > + dev_err(dev, "Failed to create region for client %s at
> > bus %d at
> > +addr 0x%02x\n",
> > data->hpdev.brdinfo->type, data->hpdev.nr,
> > data->hpdev.brdinfo->addr);
> > return PTR_ERR(mlxreg_dpu->io_regs); diff --git
> > a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-
> > lc.c
> > index aee395bb48ae4..8eef3d990d1ae 100644
> > --- a/drivers/platform/mellanox/mlxreg-lc.c
> > +++ b/drivers/platform/mellanox/mlxreg-lc.c
> > @@ -57,9 +57,9 @@ enum mlxreg_lc_state {
> > * @dev: platform device;
> > * @lock: line card lock;
> > * @par_regmap: parent device regmap handle;
> > - * @data: pltaform core data;
> > + * @data: platform core data;
> > * @io_data: register access platform data;
> > - * @led_data: LED platform data ;
> > + * @led_data: LED platform data;
> > * @mux_data: MUX platform data;
> > * @led: LED device;
> > * @io_regs: register access device;
> > @@ -171,7 +171,7 @@ static int mlxreg_lc_chan[] = {
> > 0x4e, 0x4f
> > };
> >
> > -/* Defaul mux configuration. */
> > +/* Default mux configuration. */
> > static struct mlxcpld_mux_plat_data mlxreg_lc_mux_data[] = {
> > {
> > .chan_ids = mlxreg_lc_chan,
> > @@ -181,7 +181,7 @@ static struct mlxcpld_mux_plat_data
> > mlxreg_lc_mux_data[] = {
> > },
> > };
> >
> > -/* Defaul mux board info. */
> > +/* Default mux board info. */
> > static struct i2c_board_info mlxreg_lc_mux_brdinfo = {
> > I2C_BOARD_INFO("i2c-mux-mlxcpld", 0x32), }; @@ -758,7 +758,7
> > @@ mlxreg_lc_config_init(struct mlxreg_lc *mlxreg_lc, void *regmap,
> > platform_device_register_resndata(dev, "mlxreg-io", data-
> > >hpdev.nr, NULL, 0,
> > mlxreg_lc->io_data,
> > sizeof(*mlxreg_lc->io_data));
> > if (IS_ERR(mlxreg_lc->io_regs)) {
> > - dev_err(dev, "Failed to create regio for client %s at bus
> > %d at addr 0x%02x\n",
> > + dev_err(dev, "Failed to create region for client %s at
> > bus %d at
> > +addr 0x%02x\n",
> > data->hpdev.brdinfo->type, data->hpdev.nr,
> > data->hpdev.brdinfo->addr);
> > err = PTR_ERR(mlxreg_lc->io_regs);
> > --
> > 2.46.0
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message
2025-06-22 7:29 ` [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message Alok Tiwari
@ 2025-06-25 18:12 ` Vadim Pasternak
0 siblings, 0 replies; 7+ messages in thread
From: Vadim Pasternak @ 2025-06-25 18:12 UTC (permalink / raw)
To: Alok Tiwari, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
David Thompson, Michael Shych,
platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Alok Tiwari <alok.a.tiwari@oracle.com>
> Sent: Sunday, 22 June 2025 10:29
> To: hansg@kernel.org; ilpo.jarvinen@linux.intel.com; David Thompson
> <davthompson@nvidia.com>; Michael Shych <michaelsh@nvidia.com>;
> Vadim Pasternak <vadimp@nvidia.com>; platform-driver-x86@vger.kernel.org
> Cc: alok.a.tiwari@oracle.com; linux-kernel@vger.kernel.org
> Subject: [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in
> adapter error message
>
> change error log to use correct bus number from main_mux_devs instead of
> cpld_devs.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>
> ---
> drivers/platform/mellanox/nvsw-sn2201.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mellanox/nvsw-sn2201.c
> b/drivers/platform/mellanox/nvsw-sn2201.c
> index db31c8bf22553..51504113c17ea 100644
> --- a/drivers/platform/mellanox/nvsw-sn2201.c
> +++ b/drivers/platform/mellanox/nvsw-sn2201.c
> @@ -1181,7 +1181,7 @@ static int
> nvsw_sn2201_i2c_completion_notify(void *handle, int id)
> if (!nvsw_sn2201->main_mux_devs->adapter) {
> err = -ENODEV;
> dev_err(nvsw_sn2201->dev, "Failed to get adapter for bus
> %d\n",
> - nvsw_sn2201->cpld_devs->nr);
> + nvsw_sn2201->main_mux_devs->nr);
> goto i2c_get_adapter_main_fail;
> }
>
> --
> 2.46.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
2025-06-22 7:29 [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers Alok Tiwari
` (2 preceding siblings ...)
2025-06-24 20:50 ` Vadim Pasternak
@ 2025-06-26 15:19 ` Ilpo Järvinen
3 siblings, 0 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-06-26 15:19 UTC (permalink / raw)
To: hansg, davthompson, michaelsh, vadimp, platform-driver-x86,
Alok Tiwari
Cc: linux-kernel
On Sun, 22 Jun 2025 00:29:11 -0700, Alok Tiwari wrote:
> This commit corrects several minor typographical errors in comments
> and error messages across multiple Mellanox platform driver.
> Fixed spelling of "thresholds", "region", "platform", "default",
> and removed redundant spaces in comment strings and error logs.
>
> These changes are cosmetic and do not affect runtime behavior.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers
commit: c3ac7e30309b8221a8321c3882d289ba519b4104
[2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message
commit: d07143b507c51c04c091081627c5a130e9d3c517
--
i.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-06-26 15:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-22 7:29 [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers Alok Tiwari
2025-06-22 7:29 ` [PATCH 2/2] platform/mellanox: nvsw-sn2201: Fix bus number in adapter error message Alok Tiwari
2025-06-25 18:12 ` Vadim Pasternak
2025-06-24 20:17 ` [PATCH 1/2] platform/mellanox: Fix spelling and comment clarity in Mellanox drivers David Thompson
2025-06-24 20:50 ` Vadim Pasternak
2025-06-25 12:36 ` Ilpo Järvinen
2025-06-26 15:19 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).