[PATCH] drm/dp: Clean up white space in drm_edp_backlight_probe_state()

[PATCH] drm/dp: Clean up white space in drm_edp_backlight_probe_state()

[Dan Carpenter]

This code needs to be indented one more tab.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index db7896c7edb8..1c3920297906 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -4245,14 +4245,14 @@ drm_edp_backlight_probe_state(struct drm_dp_aux *aux, struct drm_edp_backlight_i
 					    "%s: Failed to read backlight level: %d\n",
 					    aux->name, ret);
 				return ret;
-		}
+			}
 
-		/*
-		 * Incase luminance is set we want to send the value back in nits but since
-		 * DP_EDP_PANEL_TARGET_LUMINANCE stores values in millinits we need to divide
-		 * by 1000.
-		 */
-		return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
+			/*
+			 * Incase luminance is set we want to send the value back in nits but
+			 * since DP_EDP_PANEL_TARGET_LUMINANCE stores values in millinits we
+			 * need to divide by 1000.
+			 */
+			return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
 		} else {
 			ret = drm_dp_dpcd_read_data(aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
 						    buf, size);
-- 
2.47.2

RE: [PATCH] drm/dp: Clean up white space in drm_edp_backlight_probe_state()

[Kandpal, Suraj]

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Wednesday, July 2, 2025 6:25 PM
> To: Kandpal, Suraj <suraj.kandpal@intel.com>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann
> <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Simona Vetter
> <simona@ffwll.ch>; Nikula, Jani <jani.nikula@intel.com>; Deak, Imre
> <imre.deak@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com>; Dmitry
> Baryshkov <lumag@kernel.org>; Andy Yan <andy.yan@rock-chips.com>; Dave
> Airlie <airlied@redhat.com>; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH] drm/dp: Clean up white space in
> drm_edp_backlight_probe_state()
> 
> This code needs to be indented one more tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
> b/drivers/gpu/drm/display/drm_dp_helper.c
> index db7896c7edb8..1c3920297906 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -4245,14 +4245,14 @@ drm_edp_backlight_probe_state(struct
> drm_dp_aux *aux, struct drm_edp_backlight_i
>  					    "%s: Failed to read backlight level:
> %d\n",
>  					    aux->name, ret);
>  				return ret;
> -		}
> +			}
> 
> -		/*
> -		 * Incase luminance is set we want to send the value back in
> nits but since
> -		 * DP_EDP_PANEL_TARGET_LUMINANCE stores values in
> millinits we need to divide
> -		 * by 1000.
> -		 */
> -		return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
> +			/*
> +			 * Incase luminance is set we want to send the value
> back in nits but
> +			 * since DP_EDP_PANEL_TARGET_LUMINANCE stores
> values in millinits we
> +			 * need to divide by 1000.
> +			 */
> +			return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
>  		} else {
>  			ret = drm_dp_dpcd_read_data(aux,
> DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
>  						    buf, size);
> --
> 2.47.2

Re: [PATCH] drm/dp: Clean up white space in drm_edp_backlight_probe_state()

[Dmitry Baryshkov]

On Wed, 02 Jul 2025 07:55:10 -0500, Dan Carpenter wrote:
> This code needs to be indented one more tab.
> 
> 

Applied to drm-misc-next, thanks!

[1/1] drm/dp: Clean up white space in drm_edp_backlight_probe_state()
      commit: e33f256dbc293a1a3a31f18d56f659e7a27a491a

Best regards,
-- 
With best wishes
Dmitry