linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH rdma-next 1/1] RDMA/mana_ib: add additional port counters
@ 2025-07-10 10:29 Konstantin Taranov
  2025-07-12 19:16 ` Long Li
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Taranov @ 2025-07-10 10:29 UTC (permalink / raw)
  To: kotaranov, zhiyueqiu, longli, jgg, leon; +Cc: linux-rdma, linux-kernel

From: Zhiyue Qiu <zhiyueqiu@microsoft.com>

Add packet and request port counters to mana_ib.

Signed-off-by: Zhiyue Qiu <zhiyueqiu@microsoft.com>
Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
---
 drivers/infiniband/hw/mana/counters.c | 18 ++++++++++++++++++
 drivers/infiniband/hw/mana/counters.h |  8 ++++++++
 drivers/infiniband/hw/mana/mana_ib.h  |  8 ++++++++
 3 files changed, 34 insertions(+)

diff --git a/drivers/infiniband/hw/mana/counters.c b/drivers/infiniband/hw/mana/counters.c
index 6a81365..e964e74 100644
--- a/drivers/infiniband/hw/mana/counters.c
+++ b/drivers/infiniband/hw/mana/counters.c
@@ -32,6 +32,14 @@
 	[MANA_IB_RATE_INC_EVENTS].name = "rate_inc_events",
 	[MANA_IB_NUM_QPS_RECOVERED].name = "num_qps_recovered",
 	[MANA_IB_CURRENT_RATE].name = "current_rate",
+	[MANA_IB_DUP_RX_REQ].name = "dup_rx_requests",
+	[MANA_IB_TX_BYTES].name = "tx_bytes",
+	[MANA_IB_RX_BYTES].name = "rx_bytes",
+	[MANA_IB_RX_SEND_REQ].name = "rx_send_requests",
+	[MANA_IB_RX_WRITE_REQ].name = "rx_write_requests",
+	[MANA_IB_RX_READ_REQ].name = "rx_read_requests",
+	[MANA_IB_TX_PKT].name = "tx_packets",
+	[MANA_IB_RX_PKT].name = "rx_packets",
 };
 
 static const struct rdma_stat_desc mana_ib_device_stats_desc[] = {
@@ -100,6 +108,7 @@ static int mana_ib_get_hw_port_stats(struct ib_device *ibdev, struct rdma_hw_sta
 
 	mana_gd_init_req_hdr(&req.hdr, MANA_IB_QUERY_VF_COUNTERS,
 			     sizeof(req), sizeof(resp));
+	req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
 	req.hdr.dev_id = mdev->gdma_dev->dev_id;
 	req.adapter = mdev->adapter_handle;
 
@@ -148,6 +157,15 @@ static int mana_ib_get_hw_port_stats(struct ib_device *ibdev, struct rdma_hw_sta
 	stats->value[MANA_IB_NUM_QPS_RECOVERED] = resp.num_qps_recovered;
 	stats->value[MANA_IB_CURRENT_RATE] = resp.current_rate;
 
+	stats->value[MANA_IB_DUP_RX_REQ] = resp.dup_rx_req;
+	stats->value[MANA_IB_TX_BYTES] = resp.tx_bytes;
+	stats->value[MANA_IB_RX_BYTES] = resp.rx_bytes;
+	stats->value[MANA_IB_RX_SEND_REQ] = resp.rx_send_req;
+	stats->value[MANA_IB_RX_WRITE_REQ] = resp.rx_write_req;
+	stats->value[MANA_IB_RX_READ_REQ] = resp.rx_read_req;
+	stats->value[MANA_IB_TX_PKT] = resp.tx_pkt;
+	stats->value[MANA_IB_RX_PKT] = resp.rx_pkt;
+
 	return ARRAY_SIZE(mana_ib_port_stats_desc);
 }
 
diff --git a/drivers/infiniband/hw/mana/counters.h b/drivers/infiniband/hw/mana/counters.h
index 987a6fe..f68e776 100644
--- a/drivers/infiniband/hw/mana/counters.h
+++ b/drivers/infiniband/hw/mana/counters.h
@@ -35,6 +35,14 @@ enum mana_ib_port_counters {
 	MANA_IB_RATE_INC_EVENTS,
 	MANA_IB_NUM_QPS_RECOVERED,
 	MANA_IB_CURRENT_RATE,
+	MANA_IB_DUP_RX_REQ,
+	MANA_IB_TX_BYTES,
+	MANA_IB_RX_BYTES,
+	MANA_IB_RX_SEND_REQ,
+	MANA_IB_RX_WRITE_REQ,
+	MANA_IB_RX_READ_REQ,
+	MANA_IB_TX_PKT,
+	MANA_IB_RX_PKT,
 };
 
 enum mana_ib_device_counters {
diff --git a/drivers/infiniband/hw/mana/mana_ib.h b/drivers/infiniband/hw/mana/mana_ib.h
index eddd0a8..369825f 100644
--- a/drivers/infiniband/hw/mana/mana_ib.h
+++ b/drivers/infiniband/hw/mana/mana_ib.h
@@ -516,6 +516,14 @@ struct mana_rnic_query_vf_cntrs_resp {
 	u64 rate_inc_events;
 	u64 num_qps_recovered;
 	u64 current_rate;
+	u64 dup_rx_req;
+	u64 tx_bytes;
+	u64 rx_bytes;
+	u64 rx_send_req;
+	u64 rx_write_req;
+	u64 rx_read_req;
+	u64 tx_pkt;
+	u64 rx_pkt;
 }; /* HW Data */
 
 struct mana_rnic_query_device_cntrs_req {
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH rdma-next 1/1] RDMA/mana_ib: add additional port counters
  2025-07-10 10:29 [PATCH rdma-next 1/1] RDMA/mana_ib: add additional port counters Konstantin Taranov
@ 2025-07-12 19:16 ` Long Li
  0 siblings, 0 replies; 2+ messages in thread
From: Long Li @ 2025-07-12 19:16 UTC (permalink / raw)
  To: Konstantin Taranov, Konstantin Taranov, Zhiyue Qiu, jgg@ziepe.ca,
	leon@kernel.org
  Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org

> Subject: [PATCH rdma-next 1/1] RDMA/mana_ib: add additional port counters
> 
> From: Zhiyue Qiu <zhiyueqiu@microsoft.com>
> 
> Add packet and request port counters to mana_ib.
> 
> Signed-off-by: Zhiyue Qiu <zhiyueqiu@microsoft.com>
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/infiniband/hw/mana/counters.c | 18 ++++++++++++++++++
> drivers/infiniband/hw/mana/counters.h |  8 ++++++++
> drivers/infiniband/hw/mana/mana_ib.h  |  8 ++++++++
>  3 files changed, 34 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/mana/counters.c
> b/drivers/infiniband/hw/mana/counters.c
> index 6a81365..e964e74 100644
> --- a/drivers/infiniband/hw/mana/counters.c
> +++ b/drivers/infiniband/hw/mana/counters.c
> @@ -32,6 +32,14 @@
>  	[MANA_IB_RATE_INC_EVENTS].name = "rate_inc_events",
>  	[MANA_IB_NUM_QPS_RECOVERED].name = "num_qps_recovered",
>  	[MANA_IB_CURRENT_RATE].name = "current_rate",
> +	[MANA_IB_DUP_RX_REQ].name = "dup_rx_requests",
> +	[MANA_IB_TX_BYTES].name = "tx_bytes",
> +	[MANA_IB_RX_BYTES].name = "rx_bytes",
> +	[MANA_IB_RX_SEND_REQ].name = "rx_send_requests",
> +	[MANA_IB_RX_WRITE_REQ].name = "rx_write_requests",
> +	[MANA_IB_RX_READ_REQ].name = "rx_read_requests",
> +	[MANA_IB_TX_PKT].name = "tx_packets",
> +	[MANA_IB_RX_PKT].name = "rx_packets",
>  };
> 
>  static const struct rdma_stat_desc mana_ib_device_stats_desc[] = { @@ -100,6
> +108,7 @@ static int mana_ib_get_hw_port_stats(struct ib_device *ibdev, struct
> rdma_hw_sta
> 
>  	mana_gd_init_req_hdr(&req.hdr, MANA_IB_QUERY_VF_COUNTERS,
>  			     sizeof(req), sizeof(resp));
> +	req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
>  	req.hdr.dev_id = mdev->gdma_dev->dev_id;
>  	req.adapter = mdev->adapter_handle;
> 
> @@ -148,6 +157,15 @@ static int mana_ib_get_hw_port_stats(struct ib_device
> *ibdev, struct rdma_hw_sta
>  	stats->value[MANA_IB_NUM_QPS_RECOVERED] =
> resp.num_qps_recovered;
>  	stats->value[MANA_IB_CURRENT_RATE] = resp.current_rate;
> 
> +	stats->value[MANA_IB_DUP_RX_REQ] = resp.dup_rx_req;
> +	stats->value[MANA_IB_TX_BYTES] = resp.tx_bytes;
> +	stats->value[MANA_IB_RX_BYTES] = resp.rx_bytes;
> +	stats->value[MANA_IB_RX_SEND_REQ] = resp.rx_send_req;
> +	stats->value[MANA_IB_RX_WRITE_REQ] = resp.rx_write_req;
> +	stats->value[MANA_IB_RX_READ_REQ] = resp.rx_read_req;
> +	stats->value[MANA_IB_TX_PKT] = resp.tx_pkt;
> +	stats->value[MANA_IB_RX_PKT] = resp.rx_pkt;
> +
>  	return ARRAY_SIZE(mana_ib_port_stats_desc);
>  }
> 
> diff --git a/drivers/infiniband/hw/mana/counters.h
> b/drivers/infiniband/hw/mana/counters.h
> index 987a6fe..f68e776 100644
> --- a/drivers/infiniband/hw/mana/counters.h
> +++ b/drivers/infiniband/hw/mana/counters.h
> @@ -35,6 +35,14 @@ enum mana_ib_port_counters {
>  	MANA_IB_RATE_INC_EVENTS,
>  	MANA_IB_NUM_QPS_RECOVERED,
>  	MANA_IB_CURRENT_RATE,
> +	MANA_IB_DUP_RX_REQ,
> +	MANA_IB_TX_BYTES,
> +	MANA_IB_RX_BYTES,
> +	MANA_IB_RX_SEND_REQ,
> +	MANA_IB_RX_WRITE_REQ,
> +	MANA_IB_RX_READ_REQ,
> +	MANA_IB_TX_PKT,
> +	MANA_IB_RX_PKT,
>  };
> 
>  enum mana_ib_device_counters {
> diff --git a/drivers/infiniband/hw/mana/mana_ib.h
> b/drivers/infiniband/hw/mana/mana_ib.h
> index eddd0a8..369825f 100644
> --- a/drivers/infiniband/hw/mana/mana_ib.h
> +++ b/drivers/infiniband/hw/mana/mana_ib.h
> @@ -516,6 +516,14 @@ struct mana_rnic_query_vf_cntrs_resp {
>  	u64 rate_inc_events;
>  	u64 num_qps_recovered;
>  	u64 current_rate;
> +	u64 dup_rx_req;
> +	u64 tx_bytes;
> +	u64 rx_bytes;
> +	u64 rx_send_req;
> +	u64 rx_write_req;
> +	u64 rx_read_req;
> +	u64 tx_pkt;
> +	u64 rx_pkt;
>  }; /* HW Data */
> 
>  struct mana_rnic_query_device_cntrs_req {
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-12 19:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-10 10:29 [PATCH rdma-next 1/1] RDMA/mana_ib: add additional port counters Konstantin Taranov
2025-07-12 19:16 ` Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).