* [PATCH net] net: emaclite: Fix missing pointer increment in aligned_read()
@ 2025-07-10 17:38 Alok Tiwari
2025-07-12 1:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Alok Tiwari @ 2025-07-10 17:38 UTC (permalink / raw)
To: abin.joseph, radhey.shyam.pandey, michal.simek, andrew+netdev,
davem, edumazet, kuba, pabeni, horms, netdev
Cc: alok.a.tiwari, darren.kenny, linux-kernel
Add missing post-increment operators for byte pointers in the
loop that copies remaining bytes in xemaclite_aligned_read().
Without the increment, the same byte was written repeatedly
to the destination.
This update aligns with xemaclite_aligned_write()
Fixes: bb81b2ddfa19 ("net: add Xilinx emac lite device driver")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index ecf47107146dc..4719d40a63ba3 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -286,7 +286,7 @@ static void xemaclite_aligned_read(u32 *src_ptr, u8 *dest_ptr,
/* Read the remaining data */
for (; length > 0; length--)
- *to_u8_ptr = *from_u8_ptr;
+ *to_u8_ptr++ = *from_u8_ptr++;
}
}
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: emaclite: Fix missing pointer increment in aligned_read()
2025-07-10 17:38 [PATCH net] net: emaclite: Fix missing pointer increment in aligned_read() Alok Tiwari
@ 2025-07-12 1:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-12 1:00 UTC (permalink / raw)
To: Alok Tiwari
Cc: abin.joseph, radhey.shyam.pandey, michal.simek, andrew+netdev,
davem, edumazet, kuba, pabeni, horms, netdev, darren.kenny,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 10 Jul 2025 10:38:46 -0700 you wrote:
> Add missing post-increment operators for byte pointers in the
> loop that copies remaining bytes in xemaclite_aligned_read().
> Without the increment, the same byte was written repeatedly
> to the destination.
> This update aligns with xemaclite_aligned_write()
>
> Fixes: bb81b2ddfa19 ("net: add Xilinx emac lite device driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>
> [...]
Here is the summary with links:
- [net] net: emaclite: Fix missing pointer increment in aligned_read()
https://git.kernel.org/netdev/net/c/7727ec1523d7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-12 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-10 17:38 [PATCH net] net: emaclite: Fix missing pointer increment in aligned_read() Alok Tiwari
2025-07-12 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).