From: "tip-bot2 for Jinliang Zheng" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jinliang Zheng <alexjlzheng@tencent.com>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/core] locking/rwsem: Use OWNER_NONSPINNABLE directly instead of OWNER_SPINNABLE
Date: Sat, 19 Jul 2025 17:40:13 -0000 [thread overview]
Message-ID: <175294681307.1420.8503001269438279756.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250610130158.4876-1-alexjlzheng@tencent.com>
The following commit has been merged into the locking/core branch of tip:
Commit-ID: f84a15b90d96f3da99f67fea2e116850d99fb7c4
Gitweb: https://git.kernel.org/tip/f84a15b90d96f3da99f67fea2e116850d99fb7c4
Author: Jinliang Zheng <alexjlzheng@tencent.com>
AuthorDate: Tue, 10 Jun 2025 21:01:58 +08:00
Committer: Boqun Feng <boqun.feng@gmail.com>
CommitterDate: Fri, 11 Jul 2025 15:11:54 -07:00
locking/rwsem: Use OWNER_NONSPINNABLE directly instead of OWNER_SPINNABLE
After commit 7d43f1ce9dd0 ("locking/rwsem: Enable time-based spinning on
reader-owned rwsem"), OWNER_SPINNABLE contains all possible values except
OWNER_NONSPINNABLE, namely OWNER_NULL | OWNER_WRITER | OWNER_READER.
Therefore, it is better to use OWNER_NONSPINNABLE directly to determine
whether to exit optimistic spin.
And, remove useless OWNER_SPINNABLE to simplify the code.
Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250610130158.4876-1-alexjlzheng@tencent.com
---
kernel/locking/rwsem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
index 2ddb827..8572dba 100644
--- a/kernel/locking/rwsem.c
+++ b/kernel/locking/rwsem.c
@@ -727,8 +727,6 @@ static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
return ret;
}
-#define OWNER_SPINNABLE (OWNER_NULL | OWNER_WRITER | OWNER_READER)
-
static inline enum owner_state
rwsem_owner_state(struct task_struct *owner, unsigned long flags)
{
@@ -835,7 +833,7 @@ static bool rwsem_optimistic_spin(struct rw_semaphore *sem)
enum owner_state owner_state;
owner_state = rwsem_spin_on_owner(sem);
- if (!(owner_state & OWNER_SPINNABLE))
+ if (owner_state == OWNER_NONSPINNABLE)
break;
/*
prev parent reply other threads:[~2025-07-19 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 13:01 [PATCH] locking/rwsem: use OWNER_NONSPINNABLE directly instead of OWNER_SPINNABLE alexjlzheng
2025-06-13 5:52 ` Waiman Long
2025-06-17 17:13 ` Boqun Feng
2025-07-19 17:40 ` tip-bot2 for Jinliang Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175294681307.1420.8503001269438279756.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=alexjlzheng@tencent.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=longman@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).