[PATCH v2] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

[PATCH v2] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

[Rob Herring (Arm)]

Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
and "clock-names" which are already in use. As they are always present,
make them required as well.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
 - Move some description to #phy-cells
 - Make clocks/clock-names required
---
 .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 --------------
 .../bindings/phy/ti,da830-usb-phy.yaml        | 53 +++++++++++++++++++
 2 files changed, 53 insertions(+), 40 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
 create mode 100644 Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml

diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
deleted file mode 100644
index c26478be391b..000000000000
--- a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
+++ /dev/null
@@ -1,40 +0,0 @@
-TI DA8xx/OMAP-L1xx/AM18xx USB PHY
-
-Required properties:
- - compatible: must be "ti,da830-usb-phy".
- - #phy-cells: must be 1.
-
-This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
-controllers on DA8xx SoCs. Consumers of this device should use index 0 for
-the USB 2.0 phy device and index 1 for the USB 1.1 phy device.
-
-It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
-to access the CFGCHIP2 register.
-
-Example:
-
-	cfgchip: cfgchip@1417c {
-		compatible = "ti,da830-cfgchip", "syscon";
-		reg = <0x1417c 0x14>;
-	};
-
-	usb_phy: usb-phy {
-		compatible = "ti,da830-usb-phy";
-		#phy-cells = <1>;
-	};
-
-	usb20: usb@200000 {
-		compatible = "ti,da830-musb";
-		reg = <0x200000 0x1000>;
-		interrupts = <58>;
-		phys = <&usb_phy 0>;
-		phy-names = "usb-phy";
-	};
-
-	usb11: usb@225000 {
-		compatible = "ti,da830-ohci";
-		reg = <0x225000 0x1000>;
-		interrupts = <59>;
-		phys = <&usb_phy 1>;
-		phy-names = "usb-phy";
-	};
diff --git a/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
new file mode 100644
index 000000000000..1d6f30b5a159
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/ti,da830-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI DA8xx/OMAP-L1xx/AM18xx USB PHY
+
+maintainers:
+  - David Lechner <david@lechnology.com>
+
+description: >
+  This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
+  controllers on DA8xx SoCs.
+  
+  It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
+  to access the CFGCHIP2 register.
+
+properties:
+  compatible:
+    items:
+      - const: ti,da830-usb-phy
+
+  '#phy-cells':
+    const: 1
+    description:
+      Consumers of this device should use index 0 for the USB 2.0 phy device and
+      index 1 for the USB 1.1 phy device.
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: usb0_clk48
+      - const: usb1_clk48
+
+required:
+  - compatible
+  - '#phy-cells'
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    usb-phy {
+        compatible = "ti,da830-usb-phy";
+        #phy-cells = <1>;
+        clocks = <&usb_phy_clk 0>, <&usb_phy_clk 1>;
+        clock-names = "usb0_clk48", "usb1_clk48";
+    };
-- 
2.47.2

Re: [PATCH v2] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

[David Lechner]

On 6/27/25 5:01 PM, Rob Herring (Arm) wrote:
> Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
> and "clock-names" which are already in use. As they are always present,
> make them required as well.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
Reviewed-by: David Lechner <david@lechnology.com>

Re: [PATCH v2] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

[Krzysztof Kozlowski]

On Fri, Jun 27, 2025 at 05:01:06PM -0500, Rob Herring (Arm) wrote:
> +$id: http://devicetree.org/schemas/phy/ti,da830-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DA8xx/OMAP-L1xx/AM18xx USB PHY
> +
> +maintainers:
> +  - David Lechner <david@lechnology.com>
> +
> +description: >
> +  This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
> +  controllers on DA8xx SoCs.
> +  

Trailing white-space here.

Rest looks fine, so with above:


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema

[Vinod Koul]

On Fri, 27 Jun 2025 17:01:06 -0500, Rob Herring (Arm) wrote:
> Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
> and "clock-names" which are already in use. As they are always present,
> make them required as well.
> 
> 

Applied, thanks!

[1/1] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema
      commit: 99dd7faeb7a4d973f049e1bad234888777e03646

Best regards,
-- 
~Vinod