From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609EAECDFB3 for ; Mon, 16 Jul 2018 10:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A253208AD for ; Mon, 16 Jul 2018 10:09:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A253208AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729151AbeGPKfh (ORCPT ); Mon, 16 Jul 2018 06:35:37 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:50829 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727494AbeGPKfh (ORCPT ); Mon, 16 Jul 2018 06:35:37 -0400 Received: from 79.184.255.17.ipv4.supernova.orange.pl (79.184.255.17) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id 230f7a75d7260690; Mon, 16 Jul 2018 12:08:56 +0200 From: "Rafael J. Wysocki" To: Benjamin Gaignard Cc: gregkh@linuxfoundation.org, broonie@kernel.org, p.paillet@st.com, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, Benjamin Gaignard Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check Date: Mon, 16 Jul 2018 12:07:20 +0200 Message-ID: <1753469.EDefOSO2YU@aspire.rjw.lan> In-Reply-To: <20180716095952.22202-1-benjamin.gaignard@st.com> References: <20180716095952.22202-1-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote: > In some cases the link between between customer and supplier > already exist, for example when a device use it parent as supplier [1]. I think this should be "its parent as a supplier". > Do not warn about already existing dependencies because device_link_add() > take care of this case. "device_link_add() takes care of" > [1] https://lkml.org/lkml/2018/7/9/356 There is the Link: tag for links and it is better to not use lkml.org as it is not reliable enough. You can use lore.kernel.org/lkml/ instead. > Reported-by: Marek Szyprowski > Reviewed-by: Mark Brown > Signed-off-by: Benjamin Gaignard > --- > drivers/base/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index df3e1a44707a..fcdc17f0f349 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -105,7 +105,7 @@ static int device_is_dependent(struct device *dev, void *target) > struct device_link *link; > int ret; > > - if (WARN_ON(dev == target)) > + if (dev == target) > return 1; > > ret = device_for_each_child(dev, target, device_is_dependent); > @@ -113,7 +113,7 @@ static int device_is_dependent(struct device *dev, void *target) > return ret; > > list_for_each_entry(link, &dev->links.consumers, s_node) { > - if (WARN_ON(link->consumer == target)) > + if (link->consumer == target) > return 1; > > ret = device_is_dependent(link->consumer, target); >