[PATCH][next] spi: SPISG: Fix less than zero comparison on a u32 variable

[PATCH][next] spi: SPISG: Fix less than zero comparison on a u32 variable

[Colin Ian King]

The check for ns < 0 is always false because variable ns is a u32 which
is not a signed type. Fix this by making ns a s32 type.

Fixes: cef9991e04ae ("spi: Add Amlogic SPISG driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/spi/spi-amlogic-spisg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-amlogic-spisg.c b/drivers/spi/spi-amlogic-spisg.c
index 48a5325b4db7..2ab8bdf2a676 100644
--- a/drivers/spi/spi-amlogic-spisg.c
+++ b/drivers/spi/spi-amlogic-spisg.c
@@ -163,7 +163,7 @@ struct spisg_device {
 
 static int spi_delay_to_sclk(u32 slck_speed_hz, struct spi_delay *delay)
 {
-	u32 ns;
+	s32 ns;
 
 	if (!delay)
 		return 0;
-- 
2.50.0

Re: [PATCH][next] spi: SPISG: Fix less than zero comparison on a u32 variable

[Mark Brown]

On Fri, 25 Jul 2025 18:17:01 +0100, Colin Ian King wrote:
> The check for ns < 0 is always false because variable ns is a u32 which
> is not a signed type. Fix this by making ns a s32 type.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: SPISG: Fix less than zero comparison on a u32 variable
      commit: 2d442a0c781403702de27ccfbc4bb233721585f5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH][next] spi: SPISG: Fix less than zero comparison on a u32 variable

[Xianwei Zhao]

Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
On 2025/7/26 01:17, Colin Ian King wrote:
> [Some people who received this message don't often get email from colin.i.king@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
> The check for ns < 0 is always false because variable ns is a u32 which
> is not a signed type. Fix this by making ns a s32 type.
> 
> Fixes: cef9991e04ae ("spi: Add Amlogic SPISG driver")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   drivers/spi/spi-amlogic-spisg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-amlogic-spisg.c b/drivers/spi/spi-amlogic-spisg.c
> index 48a5325b4db7..2ab8bdf2a676 100644
> --- a/drivers/spi/spi-amlogic-spisg.c
> +++ b/drivers/spi/spi-amlogic-spisg.c
> @@ -163,7 +163,7 @@ struct spisg_device {
> 
>   static int spi_delay_to_sclk(u32 slck_speed_hz, struct spi_delay *delay)
>   {
> -       u32 ns;
> +       s32 ns;
> 
>          if (!delay)
>                  return 0;
> --
> 2.50.0
>