From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53967ECE566 for ; Thu, 20 Sep 2018 13:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EDFB2150E for ; Thu, 20 Sep 2018 13:11:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WUeGnraN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EDFB2150E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387938AbeITSyc (ORCPT ); Thu, 20 Sep 2018 14:54:32 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54874 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387418AbeITSyc (ORCPT ); Thu, 20 Sep 2018 14:54:32 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FC051A9C; Thu, 20 Sep 2018 15:11:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537449062; bh=KzxRfSGlTG36QHbdDuu62BeSdIst1dfK7oU07zhAYc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WUeGnraNABJEJEzRS/aRinOpk/UIHEUmYoyFBLE32o5QB0hw8npyLHHAmEVuhwSeX mFqbhchjZDkbk6BrzCnKdj0gMp/y1nV+nrRwK1AWILdbEQY/+NpbfdgzJwP20Vgily 4kjNchrjHc8IojTAXY4PURss4Z1sVtpOLG8EMZlk= From: Laurent Pinchart To: Luis Oliveira Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Joao.Pinto@synopsys.com, festevam@gmail.com, Luis Oliveira , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , Geert Uytterhoeven , Laurent Pinchart , Arnd Bergmann , Jacob Chen , Neil Armstrong , Keiichi Watanabe , Kate Stewart , Philipp Zabel , Todor Tomov , devicetree@vger.kernel.org Subject: Re: [V2, 2/5] Documentation: dt-bindings: Document the Synopsys MIPI DPHY Rx bindings Date: Thu, 20 Sep 2018 16:11:14 +0300 Message-ID: <1754496.WQhu2lOnZY@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180920111648.27000-3-lolivei@synopsys.com> References: <20180920111648.27000-1-lolivei@synopsys.com> <20180920111648.27000-3-lolivei@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Louis, Thank you for the patch. On Thursday, 20 September 2018 14:16:40 EEST Luis Oliveira wrote: > Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in > RX mode. > > Signed-off-by: Luis Oliveira > --- > Changelog > v2: > - no changes > > .../devicetree/bindings/phy/snps,dphy-rx.txt | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > > diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt new file mode > 100644 > index 0000000..9079f4a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > @@ -0,0 +1,36 @@ > +Synopsys DesignWare MIPI Rx D-PHY block details > + > +Description > +----------- > + > +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. > +Please refer to phy-bindings.txt for more information. > + > +Required properties: > +- compatible : Shall be "snps,dphy-rx". > +- #phy-cells : Must be 1. > +- snps,dphy-frequency : Output frequency of the D-PHY. If that's the frequency of the clock on the output side of the RX PHY, doesn't it depend on the frequency on the CSI-2 (or other) bus ? Can't it vary ? Why do you need to have it in DT ? > +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or > 12bits->12). We have similar properties in various bindings, such as bus-width in video- interfaces.txt. Couldn't we use a more standard name ? > +- reg : Physical base address and size of the device memory mapped > + registers; The example below shows three ranges. Could you document the ranges that are expected ? > +Optional properties: > +- snps,compat-mode : Compatibility mode control What is this ? > +The per-board settings: > +- gpios : Synopsys testchip used as reference uses this to change setup > + configurations. Here too, what is this for ? > +Example: > + > + mipi_dphy_rx1: dphy@3040 { > + compatible = "snps,dphy-rx"; > + #phy-cells = <1>; > + snps,dphy-frequency = <300000>; > + snps,dphy-te-len = <12>; > + snps,compat-mode = <1>; > + reg = < 0x03040 0x20 > + 0x08000 0x100 > + 0x09000 0x100>; The base addresses are pretty low, what kind of bus does this sit on ? > + }; > + -- Regards, Laurent Pinchart