Re: [PATCH 2/5] Char: isicom, fix probe race

Andrew Morton
2006-12-18T23:27:40Z

On Sat, 16 Dec 2006 02:09:48 +0100 (CET)
Jiri Slaby <jirislaby@gmail.com> wrote:

> isicom, fix probe race
>
> Fix two race conditions in the probe function with mutex.
>
> ...
>
> static int __devinit isicom_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> + static DEFINE_MUTEX(probe_lock);

hm. How can isicom_probe() race with itself? Even with the dreaded
multithreaded-pci-probing? It's only called once, by a single thread.

Confused.