From: Jens Axboe <axboe@kernel.dk>
To: ming.lei@redhat.com, jianchao.w.wang@oracle.com,
linan666@huaweicloud.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yangerkun@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH] blk-mq: check kobject state_in_sysfs before deleting in blk_mq_unregister_hctx
Date: Thu, 28 Aug 2025 19:21:29 -0600 [thread overview]
Message-ID: <175643048957.32759.11740311974610130180.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250826084854.1030545-1-linan666@huaweicloud.com>
On Tue, 26 Aug 2025 16:48:54 +0800, linan666@huaweicloud.com wrote:
> In __blk_mq_update_nr_hw_queues() the return value of
> blk_mq_sysfs_register_hctxs() is not checked. If sysfs creation for hctx
> fails, later changing the number of hw_queues or removing disk will
> trigger the following warning:
>
> kernfs: can not remove 'nr_tags', no directory
> WARNING: CPU: 2 PID: 637 at fs/kernfs/dir.c:1707 kernfs_remove_by_name_ns+0x13f/0x160
> Call Trace:
> remove_files.isra.1+0x38/0xb0
> sysfs_remove_group+0x4d/0x100
> sysfs_remove_groups+0x31/0x60
> __kobject_del+0x23/0xf0
> kobject_del+0x17/0x40
> blk_mq_unregister_hctx+0x5d/0x80
> blk_mq_sysfs_unregister_hctxs+0x94/0xd0
> blk_mq_update_nr_hw_queues+0x124/0x760
> nullb_update_nr_hw_queues+0x71/0xf0 [null_blk]
> nullb_device_submit_queues_store+0x92/0x120 [null_blk]
>
> [...]
Applied, thanks!
[1/1] blk-mq: check kobject state_in_sysfs before deleting in blk_mq_unregister_hctx
commit: 4c7ef92f6d4d08a27d676e4c348f4e2922cab3ed
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-08-29 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 8:48 [PATCH] blk-mq: check kobject state_in_sysfs before deleting in blk_mq_unregister_hctx linan666
2025-08-27 0:53 ` Yu Kuai
2025-08-27 0:58 ` Ming Lei
2025-08-27 1:04 ` Yu Kuai
2025-08-27 1:35 ` Ming Lei
2025-08-27 3:22 ` Li Nan
2025-08-27 8:10 ` Ming Lei
2025-08-28 9:28 ` Li Nan
2025-08-28 12:08 ` Ming Lei
2025-08-28 17:23 ` Jens Axboe
2025-08-29 1:09 ` Yu Kuai
2025-08-29 1:20 ` Jens Axboe
2025-08-29 1:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175643048957.32759.11740311974610130180.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linan666@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox