From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: "Pavel Machek" <pavel@ucw.cz>,
"David Herrmann" <dh.herrmann@gmail.com>,
akpm@linux-foundation.org, jslaby@suse.cz,
"Bryan Wu" <cooloney@gmail.com>,
rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
"Evan Broder" <evan@ebroder.net>,
"Arnaud Patard" <arnaud.patard@rtp-net.org>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Rob Clark" <robdclark@gmail.com>,
"Niels de Vos" <devos@fedoraproject.org>,
linux-arm-kernel@lists.infradead.org, blogic@openwrt.org,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCHv5 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs
Date: Thu, 22 Jan 2015 16:37:02 -0800 [thread overview]
Message-ID: <1756449.aIckN0M451@dtor-glaptop> (raw)
In-Reply-To: <20150123003011.GC3123@type.youpi.perso.aquilenet.fr>
On Friday, January 23, 2015 01:30:11 AM Samuel Thibault wrote:
> Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit :
> > Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
> > > > + dev = cdev->dev->platform_data;
> > >
> > > Umm, platform data is not the best place for storing this. Why not
> > > drvdata?
> >
> > Ah, actually led_classdev already makes use of it, see the
> > device_create_with_groups call in led_classdev_register.
>
> Actually I'd say it makes sense to be using the platform_data field:
> from the point of view of the led object, the input object is indeed
> something like a platform.
No, platform data is what difefrentiates an arm board from another arm board,
or an x86 or mips one.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-01-23 0:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 23:21 [PATCHv5 0/2] INPUT: Route keyboard LEDs through the generic LEDs layer Samuel Thibault
2014-12-26 23:21 ` [PATCHv5 1/2] INPUT: Introduce generic trigger/LED pairs between keyboard modifiers and input LEDs Samuel Thibault
2014-12-26 23:23 ` [PATCHv5 2/2] INPUT: Introduce generic trigger/LED pairs to " Samuel Thibault
2015-01-04 23:28 ` Dmitry Torokhov
2015-01-04 23:45 ` Samuel Thibault
2015-01-05 17:42 ` Dmitry Torokhov
2015-01-05 18:00 ` Samuel Thibault
2015-01-23 0:10 ` Samuel Thibault
2015-01-23 0:30 ` Samuel Thibault
2015-01-23 0:37 ` Dmitry Torokhov [this message]
2015-01-23 0:44 ` Samuel Thibault
2015-01-23 0:51 ` Dmitry Torokhov
2015-01-23 0:54 ` Samuel Thibault
2015-01-02 19:53 ` [PATCHv5 0/2] INPUT: Route keyboard LEDs through the generic LEDs layer Pavel Machek
2015-01-02 20:11 ` Samuel Thibault
2015-01-03 19:47 ` Pavel Machek
2015-01-21 15:21 ` Samuel Thibault
2015-01-23 12:31 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1756449.aIckN0M451@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnaud.patard@rtp-net.org \
--cc=blogic@openwrt.org \
--cc=cooloney@gmail.com \
--cc=devos@fedoraproject.org \
--cc=dh.herrmann@gmail.com \
--cc=evan@ebroder.net \
--cc=jacmet@sunsite.dk \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=robdclark@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=s.hauer@pengutronix.de \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox