* [PATCH] arm64: dts: rockchip: fix USB on RADXA ROCK 5T
@ 2025-08-25 7:27 Nicolas Frattaroli
2025-09-01 10:59 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Frattaroli @ 2025-08-25 7:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: FUKAUMI Naoki, kernel, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, Nicolas Frattaroli
The RADXA ROCK 5T board uses the same GPIO pin for controlling the USB
host port regulator. This control pin was mistakenly left out of the
ROCK 5T device tree.
Reported-by: FUKAUMI Naoki <naoki@radxa.com>
Closes: https://libera.catirclogs.org/linux-rockchip/2025-08-25#38609886;
Fixes: 0ea651de9b79 ("arm64: dts: rockchip: add ROCK 5T device tree")
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts
index 258c7400301d7f77517197ab433946bbfa39cf63..6acc7a8a5a12eee9cd3506910b40235813ec43b1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts
@@ -95,6 +95,12 @@ hp_detect: hp-detect {
rockchip,pins = <4 RK_PC3 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ usb {
+ vcc5v0_host_en: vcc5v0-host-en {
+ rockchip,pins = <1 RK_PA1 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
&vcc3v3_pcie2x1l0 {
@@ -103,3 +109,10 @@ &vcc3v3_pcie2x1l0 {
pinctrl-0 = <&pcie2_0_vcc3v3_en>;
status = "okay";
};
+
+&vcc5v0_host {
+ enable-active-high;
+ gpio = <&gpio1 RK_PA1 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_host_en>;
+};
---
base-commit: 89d926fa53d0a6c257c4e8ac1c00c3d9a194ef31
change-id: 20250825-rock5t-usb-fix-6b0d04e2eae1
Best regards,
--
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix USB on RADXA ROCK 5T
2025-08-25 7:27 [PATCH] arm64: dts: rockchip: fix USB on RADXA ROCK 5T Nicolas Frattaroli
@ 2025-09-01 10:59 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-09-01 10:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Frattaroli
Cc: Heiko Stuebner, FUKAUMI Naoki, kernel, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On Mon, 25 Aug 2025 09:27:08 +0200, Nicolas Frattaroli wrote:
> The RADXA ROCK 5T board uses the same GPIO pin for controlling the USB
> host port regulator. This control pin was mistakenly left out of the
> ROCK 5T device tree.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: fix USB on RADXA ROCK 5T
commit: 63ddc0a75b3b071f04f4bc277b2510eb06d21648
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-01 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-25 7:27 [PATCH] arm64: dts: rockchip: fix USB on RADXA ROCK 5T Nicolas Frattaroli
2025-09-01 10:59 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).