linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: j721e: Fix module autoloading
@ 2025-09-01 12:03 Siddharth Vadapalli
  2025-09-01 15:41 ` Manivannan Sadhasivam
  0 siblings, 1 reply; 2+ messages in thread
From: Siddharth Vadapalli @ 2025-09-01 12:03 UTC (permalink / raw)
  To: lpieralisi, kwilczynski, mani, robh, bhelgaas, vigneshr
  Cc: stable, linux-pci, linux-omap, linux-kernel, linux-arm-kernel,
	srk, s-vadapalli

Commit under Fixes added support to build the driver as a loadable
module. However, it did not add MODULE_DEVICE_TABLE() which is required
for autoloading the driver when it is built as a loadable module.

Fix it.

Fixes: a2790bf81f0f ("PCI: j721e: Add support to build as a loadable module")
Cc: <stable@vger.kernel.org>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---

Hello,

This patch is based on commit
b320789d6883 Linux 6.17-rc4
of Mainline Linux.

Patch has been tested on J7200-EVM with the driver configs set to 'm'.
The pci-j721e.c driver is autoloaded as Linux boots and it doesn't need
to be manually probed. Logs:
https://gist.github.com/Siddharth-Vadapalli-at-TI/f64eed4df6fd4f714747b3c7e7876f24

Regards,
Siddharth.

 drivers/pci/controller/cadence/pci-j721e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index 6c93f39d0288..cfca13a4c840 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -440,6 +440,7 @@ static const struct of_device_id of_j721e_pcie_match[] = {
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, of_j721e_pcie_match);
 
 static int j721e_pcie_probe(struct platform_device *pdev)
 {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: j721e: Fix module autoloading
  2025-09-01 12:03 [PATCH] PCI: j721e: Fix module autoloading Siddharth Vadapalli
@ 2025-09-01 15:41 ` Manivannan Sadhasivam
  0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2025-09-01 15:41 UTC (permalink / raw)
  To: lpieralisi, kwilczynski, robh, bhelgaas, vigneshr,
	Siddharth Vadapalli
  Cc: stable, linux-pci, linux-omap, linux-kernel, linux-arm-kernel,
	srk


On Mon, 01 Sep 2025 17:33:55 +0530, Siddharth Vadapalli wrote:
> Commit under Fixes added support to build the driver as a loadable
> module. However, it did not add MODULE_DEVICE_TABLE() which is required
> for autoloading the driver when it is built as a loadable module.
> 
> Fix it.
> 
> 
> [...]

Applied, thanks!

[1/1] PCI: j721e: Fix module autoloading
      commit: 9a7f144e18dc5f037d85a0f0d99524a574331098

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-01 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 12:03 [PATCH] PCI: j721e: Fix module autoloading Siddharth Vadapalli
2025-09-01 15:41 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).