[PATCH] soc: qcom: rpmh-rsc: Unconditionally clear _TRIGGER bit for TCS

[PATCH] soc: qcom: rpmh-rsc: Unconditionally clear _TRIGGER bit for TCS

[Sneh Mankad]

Unconditionally clear the TCS_AMC_MODE_TRIGGER bit when a
transaction completes. Previously this bit was only cleared when
a wake TCS was borrowed as an AMC TCS but not for dedicated
AMC TCS. Leaving this bit set for AMC TCS and entering deeper low
power modes can generate a false completion IRQ.

Prevent this scenario by always clearing the TCS_AMC_MODE_TRIGGER
bit upon receiving a completion IRQ.

Fixes: 15b3bf61b8d4 ("soc: qcom: rpmh-rsc: Clear active mode configuration for wake TCS")
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
---
 drivers/soc/qcom/rpmh-rsc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1..c6f7d5c9c493d9e06c048930b8a14a38660df4b1 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -453,13 +453,10 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
 
 		trace_rpmh_tx_done(drv, i, req);
 
-		/*
-		 * If wake tcs was re-purposed for sending active
-		 * votes, clear AMC trigger & enable modes and
+		/* Clear AMC trigger & enable modes and
 		 * disable interrupt for this TCS
 		 */
-		if (!drv->tcs[ACTIVE_TCS].num_tcs)
-			__tcs_set_trigger(drv, i, false);
+		__tcs_set_trigger(drv, i, false);
 skip:
 		/* Reclaim the TCS */
 		write_tcs_reg(drv, drv->regs[RSC_DRV_CMD_ENABLE], i, 0);

---
base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
change-id: 20250818-rpmh_rsc_change-a43e43ac48aa

Best regards,
-- 
Sneh Mankad <sneh.mankad@oss.qualcomm.com>

Re: [PATCH] soc: qcom: rpmh-rsc: Unconditionally clear _TRIGGER bit for TCS

[Bjorn Andersson]

On Mon, 25 Aug 2025 11:53:50 +0530, Sneh Mankad wrote:
> Unconditionally clear the TCS_AMC_MODE_TRIGGER bit when a
> transaction completes. Previously this bit was only cleared when
> a wake TCS was borrowed as an AMC TCS but not for dedicated
> AMC TCS. Leaving this bit set for AMC TCS and entering deeper low
> power modes can generate a false completion IRQ.
> 
> Prevent this scenario by always clearing the TCS_AMC_MODE_TRIGGER
> bit upon receiving a completion IRQ.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: rpmh-rsc: Unconditionally clear _TRIGGER bit for TCS
      commit: f87412d18edb5b8393eb8cb1c2d4a54f90185a21

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>