From: "tip-bot2 for Brian Norris" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Brian Norris <briannorris@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Gow <davidgow@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] genirq/test: Ensure CPU 1 is online for hotplug test
Date: Wed, 03 Sep 2025 15:12:26 -0000 [thread overview]
Message-ID: <175691234688.1920.17485143048251122696.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250822190140.2154646-7-briannorris@chromium.org>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 8ad25ebfa70e86860559b306bbc923c7db4fcac6
Gitweb: https://git.kernel.org/tip/8ad25ebfa70e86860559b306bbc923c7db4fcac6
Author: Brian Norris <briannorris@chromium.org>
AuthorDate: Fri, 22 Aug 2025 11:59:07 -07:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Sep 2025 17:04:52 +02:00
genirq/test: Ensure CPU 1 is online for hotplug test
It's possible to run these tests on platforms that think they have a
hotpluggable CPU1, but for whatever reason, CPU1 is not online and can't be
brought online:
# irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:210
Expected remove_cpu(1) == 0, but
remove_cpu(1) == 1 (0x1)
CPU1: failed to boot: -38
# irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:214
Expected add_cpu(1) == 0, but
add_cpu(1) == -38 (0xffffffffffffffda)
Check that CPU1 is actually online before trying to run the test.
Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/all/20250822190140.2154646-7-briannorris@chromium.org
---
kernel/irq/irq_test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c
index bbb89a3..e2d3191 100644
--- a/kernel/irq/irq_test.c
+++ b/kernel/irq/irq_test.c
@@ -179,6 +179,8 @@ static void irq_cpuhotplug_test(struct kunit *test)
kunit_skip(test, "requires more than 1 CPU for CPU hotplug");
if (!cpu_is_hotpluggable(1))
kunit_skip(test, "CPU 1 must be hotpluggable");
+ if (!cpu_online(1))
+ kunit_skip(test, "CPU 1 must be online");
cpumask_copy(&affinity.mask, cpumask_of(1));
next prev parent reply other threads:[~2025-09-03 15:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 18:59 [PATCH v2 0/6] genirq/test: Platform/architecture fixes Brian Norris
2025-08-22 18:59 ` [PATCH v2 1/6] genirq/test: Select IRQ_DOMAIN Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 2/6] genirq/test: Factor out fake-virq setup Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 3/6] genirq/test: Fail early if we can't request an IRQ Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] genirq/test: Fail early if interrupt request fails tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 4/6] genirq/test: Depend on SPARSE_IRQ Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-08-23 6:59 ` David Gow
2025-08-25 21:23 ` Brian Norris
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 5/6] genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions Brian Norris
2025-08-23 1:13 ` Guenter Roeck
2025-09-03 15:12 ` [tip: irq/core] " tip-bot2 for Brian Norris
2025-08-22 18:59 ` [PATCH v2 6/6] genirq/test: Ensure CPU 1 is online for hotplug test Brian Norris
2025-08-23 1:14 ` Guenter Roeck
2025-09-03 15:12 ` tip-bot2 for Brian Norris [this message]
2025-08-22 23:26 ` [PATCH v2 0/6] genirq/test: Platform/architecture fixes Guenter Roeck
2025-08-23 1:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175691234688.1920.17485143048251122696.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).